-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Enable score based balance channel policy #38143
base: master
Are you sure you want to change the base?
enhance: Enable score based balance channel policy #38143
Conversation
current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. Signed-off-by: Wei Liu <[email protected]>
50bd48a
to
e175a84
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38143 +/- ##
===========================================
+ Coverage 68.87% 81.11% +12.24%
===========================================
Files 289 1370 +1081
Lines 25484 191284 +165800
===========================================
+ Hits 17551 155163 +137612
- Misses 7933 30641 +22708
- Partials 0 5480 +5480
|
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
issue: #38142
current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered.
This PR enable score based balance channel policy, to achieve: