Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] empty analyzer params not use standard tokenizer #38149

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 2, 2024

relate: #35853
pr: #38148

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 2, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@aoiasd Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Dec 2, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (fcbed3a) to head (6726134).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38149       +/-   ##
===========================================
+ Coverage   68.87%   81.04%   +12.16%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190679   +165198     
===========================================
+ Hits        17551   154539   +136988     
- Misses       7930    30649    +22719     
- Partials        0     5491     +5491     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.21% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/util/function/bm25_function.go 80.58% <100.00%> (ø)

... and 1070 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants