CSS rules #10
CSS rules #10
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
WalkthroughThe recent changes focus on enhancing the structure and readability of various configuration and documentation files, particularly related to GitHub Actions workflows and CSS management. Key updates include reformatting YAML files for consistency, improving the organization of markdown templates, and introducing a dynamic system for CSS rules and variants, all while preserving original functionality and content. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 6b4760dbdd256d77db481b038b49d66b43681acd (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default VariantsIt is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range, codebase verification and nitpick comments (1)
text/002-css-rules.md (1)
257-257: Improve Wordiness.Consider replacing "by the use of" with "using" for conciseness.
- This can be expressed by the use of the generic `recipe`. + This can be expressed using the generic `recipe`.Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- text/002-css-rules.md (1 hunks)
Additional context used
LanguageTool
text/002-css-rules.md
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
[grammar] ~249-~249: Did you mean “are” or “were”?
Context: ... }, }, ], }); ``` Variants is an example of declarative dynamic styli...(SENT_START_NNS_IS)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
[style] ~335-~335: To form a complete sentence, be sure to include a subject.
Context: ...w special cases like props, toggles. 3. Should be available for use withcssVariant....(MISSING_IT_THERE)
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
[grammar] ~939-~939: The plural noun “variants” cannot be used with the article “a”. Did you mean “a very powerful variant” or “very powerful variants”?
Context: ... alternatives PandaCSS is implementing a very powerful variants feature([Recipes](https://panda-css.com...(A_NNS)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (4)
text/002-css-rules.md (4)
3-6: Summary Section Looks Good!The summary is concise and provides relevant references for further reading.
8-15: Motivation Section Looks Good!The motivations are clearly stated and relevant to the context.
142-179: Mixin Section Looks Good!The section clearly compares SCSS mixins with JavaScript functions for styling.
948-986: Future Possibilities Section Looks Good!The section outlines potential future developments effectively.
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 65949b26552d4d5a85f4e8b6487381e6e391a2b8 (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default VariantsIt is possible to fast forward |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 65949b26552d4d5a85f4e8b6487381e6e391a2b8 (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (32)
000-template.md (8)
18-18: Consider using the subjunctive mood.The sentence "Explain the proposal as if it was already included..." could be more formally expressed using the subjunctive mood: "Explain the proposal as if it were already included..."
- Explain the proposal as if it was already included in the CSS-in-JS library and you were teaching it to another CSS-in-JS developer. + Explain the proposal as if it were already included in the CSS-in-JS library and you were teaching it to another CSS-in-JS developer.Tools
LanguageTool
[grammar] ~18-~18: You can use the subjunctive mood in this context.
Context: ...nationExplain the proposal as if it was already included in the CSS-in-JS libra...
(SUBJUNCTIVE_MOOD)
[uncategorized] ~18-~18: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lready included in the CSS-in-JS library and you were teaching it to another CSS-in-...(COMMA_COMPOUND_SENTENCE)
18-18: Add a comma before 'and'.Consider adding a comma before 'and' to separate independent clauses: "...library, and you were teaching..."
- Explain the proposal as if it were already included in the CSS-in-JS library and you were teaching it to another CSS-in-JS developer. + Explain the proposal as if it were already included in the CSS-in-JS library, and you were teaching it to another CSS-in-JS developer.Tools
LanguageTool
[grammar] ~18-~18: You can use the subjunctive mood in this context.
Context: ...nationExplain the proposal as if it was already included in the CSS-in-JS libra...
(SUBJUNCTIVE_MOOD)
[uncategorized] ~18-~18: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lready included in the CSS-in-JS library and you were teaching it to another CSS-in-...(COMMA_COMPOUND_SENTENCE)
47-47: Simplify the phrase 'in the space of'.The phrase "in the space of possible designs" can be simplified to "among possible designs."
- Why is this design the best in the space of possible designs? + Why is this design the best among possible designs?Tools
LanguageTool
[style] ~47-~47: ‘in the space of’ might be wordy. Consider a shorter alternative.
Context: ...atives
- Why is this design the best in the space of possible designs?
- What other designs...
(EN_WORDINESS_PREMIUM_IN_THE_SPACE_OF)
48-48: Add a comma before 'and'.Consider adding a comma before 'and' to separate independent clauses: "...considered, and what is the rationale..."
- What other designs have been considered and what is the rationale for not choosing them? + What other designs have been considered, and what is the rationale for not choosing them?Tools
LanguageTool
[uncategorized] ~48-~48: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... What other designs have been considered and what is the rationale for not choosing ...(COMMA_COMPOUND_SENTENCE_2)
57-57: Avoid repetitive sentence beginnings.The section contains three successive sentences beginning with "What." Consider rewording for variety.
- What parts of the design do you expect to resolve through the RFC process before this gets merged? - What parts of the design do you expect to resolve through the implementation of this feature before stabilization? - What related issues do you consider out of scope for this RFC that could be addressed in the future independently of the solution that comes out of this RFC? + Which design aspects do you expect to resolve through the RFC process before merging? + Which elements might be resolved during implementation before stabilization? + Are there related issues considered out of scope for this RFC that could be addressed independently in the future?Tools
LanguageTool
[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...f this feature before stabilization?
- What related issues do you consider out of s...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
62-62: Add a comma after 'would'.Add a comma after "would" for clarity: "...your proposal would, be and how it would affect..."
- Think about what the natural extension and evolution of your proposal would - be and how it would affect the library and project as a whole in a holistic + Think about what the natural extension and evolution of your proposal would, + be and how it would affect the library and project as a whole in a holisticTools
LanguageTool
[uncategorized] ~62-~62: Possible missing comma found.
Context: ...n and evolution of your proposal would
be and how it would affect the library and...(AI_HYDRA_LEO_MISSING_COMMA)
67-67: Correct the spelling of 'sub-team'.The word "sub-team" should be spelled as one word: "subteam."
- and of the relevant sub-team. + and of the relevant subteam.Tools
LanguageTool
[misspelling] ~67-~67: This word is normally spelled as one.
Context: ...ap for the project
and of the relevant sub-team.This is also a good place to "dump ...
(EN_COMPOUNDS_SUB_TEAM)
4-4: Remove unused link reference definitions.The link reference definitions are unused and can be removed to clean up the document.
- [summary]: #summary - [motivation]: #motivation - [guide-level-explanation]: #guide-level-explanation - [reference-level-explanation]: #reference-level-explanation - [drawbacks]: #drawbacks - [rationale-and-alternatives]: #rationale-and-alternatives - [unresolved-questions]: #unresolved-questions - [future-possibilities]: #future-possibilitiesAlso applies to: 9-9, 16-16, 29-29, 40-40, 45-45, 53-53, 60-60
Tools
Markdownlint
4-4: Unused link or image reference definition: "summary"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
text/000-css-literals.md (5)
418-418: Add missing article.The sentence "fontFamily$ is used as special case..." is missing an article. It should be "as a special case."
- fontFamily$ is used as special case of the `Merge Values` rule. + fontFamily$ is used as a special case of the `Merge Values` rule.Tools
LanguageTool
[uncategorized] ~418-~418: Possible missing article found.
Context: ...ble inline.
fontFamily$is used as special case of theMerge Valuesrule.**C...
(AI_HYDRA_LEO_MISSING_A)
527-527: Simplify the phrase 'a lot of'.The phrase "a lot of" can be simplified to "many" for conciseness.
- If you make a lot of things top level, it can become difficult to make them type-safe. + If you make many things top level, it can become difficult to make them type-safe.Tools
LanguageTool
[style] ~527-~527: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...erence-level explanationIf you make a lot of things top level, it can become difficu...
(A_LOT_OF)
565-565: Consider a less frequent alternative for 'in many cases'.The phrase "in many cases" is frequently used. Consider using "often" or "frequently" to vary the language.
- `kebab-case` is not available and in many cases must be represented using a string of values. + `kebab-case` is not available and often must be represented using a string of values.Tools
LanguageTool
[style] ~565-~565: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...e.
kebab-caseis not available and in many cases must be represented using a string of v...(IN_MANY_STYLE_CASES)
646-646: Avoid using 'very'.The intensifier "very" is overused. Consider removing it for a stronger statement.
- is a very big competitor and substitute. + is a big competitor and substitute.Tools
LanguageTool
[style] ~646-~646: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...roup/awesome-css#preprocessors-pill) is a very big competitor and substitute.In the CS...
(EN_WEAK_ADJECTIVE)
523-523: Remove spaces inside code span elements.There are spaces inside the code span elements that should be removed for consistency.
- - `css()` is alised to `style()` + - `css()` is aliased to `style()`Tools
Markdownlint
523-523: null
Spaces inside code span elements(MD038, no-space-in-code)
523-523: null
Spaces inside code span elements(MD038, no-space-in-code)
text/001-css-nesting.md (9)
67-67: Use a hyphen for 'Property based condition'.The phrase "Property based condition" should be hyphenated as "Property-based condition."
- Uppercase it to distinguish it from `Property based condition`. + Uppercase it to distinguish it from `Property-based condition`.Tools
LanguageTool
[uncategorized] ~67-~67: This expression is usually spelled with a hyphen.
Context: ...Uppercase it to distinguish it from
Property based condition.
[Vendor Prefixes](./000-...(BASED_HYPHEN)
99-99: Use a hyphen for 'Property based condition'.The phrase "Property based condition" should be hyphenated as "Property-based condition."
- ## 3. Property based condition + ## 3. Property-based conditionTools
LanguageTool
[uncategorized] ~99-~99: This expression is usually spelled with a hyphen.
Context: ... transition-delay: 2s;
}## 3. Property based condition Inspired by the [Panda CSS](... (BASED_HYPHEN) </blockquote></details> </details> --- `339-339`: **Use a hyphen for 'Property based condition'.** The phrase "Property based condition" should be hyphenated as "Property-based condition." ```diff - It can be used with `Property based condition`. + It can be used with `Property-based condition`.Tools
LanguageTool
[uncategorized] ~339-~339: This expression is usually spelled with a hyphen.
Context: ...ue;
}
}It can be used with `Property based condition`. **Code:** ```typescript... (BASED_HYPHEN) </blockquote></details> </details> --- `537-537`: **Avoid loose punctuation marks.** The punctuation marks after numbers in lists should be consistent and not left open. ```diff - 1. `@media`: Apply styles based on screen size or device characteristics. - 2. `@supports:` Check for support for specific features first. - 3. `@container`: Apply styles based on the size or characteristics of a specific container. - 4. `@layer`: Define the priority of the style. - 5. selectors: Apply the actual style. + 1. `@media`: Apply styles based on screen size or device characteristics. + 2. `@supports`: Check for support for specific features first. + 3. `@container`: Apply styles based on the size or characteristics of a specific container. + 4. `@layer`: Define the priority of the style. + 5. selectors: Apply the actual style.Also applies to: 539-539, 540-540, 555-555, 556-556, 557-557, 558-558, 571-571, 572-572, 573-573
Tools
LanguageTool
[uncategorized] ~537-~537: Loose punctuation mark.
Context: ...@layer) and selectors.
@media: Apply styles based on screen size or de...(UNLIKELY_OPENING_PUNCTUATION)
556-556: Add missing article 'the'.The sentence "If it's on top, browser can avoid unnecessary style calculations." is missing the article "the" before "browser."
- If it's on top, browser can avoid unnecessary style calculations. + If it's on top, the browser can avoid unnecessary style calculations.Tools
LanguageTool
[uncategorized] ~556-~556: Loose punctuation mark.
Context: ...s on the outermost part.
2.@supports: If it's on top, browser can avoid unnec...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~556-~556: You might be missing the article “the” here.
Context: ... part.
2.@supports: If it's on top, browser can avoid unnecessary style calculation...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
655-655: Use a synonym for 'hard to'.The phrase "hard to know" can be replaced with "difficult to understand" for clarity.
- but if abused, it can be hard to know the context. + but if abused, it can be difficult to understand the context.Tools
LanguageTool
[style] ~655-~655: To elevate your writing, try using a synonym here.
Context: ...s duplication, but if abused, it can be hard to know the context.Rationale and...
(HARD_TO)
663-663: Correct double punctuation.The syntax "^[N..M]" contains two consecutive dots. Ensure this is intentional or correct it.
- Using the `^[N]`, `^[N..M]` syntax, You can reference the parent, but it's confusing. + Using the `^[N]`, `^[N...M]` syntax, You can reference the parent, but it's confusing.Tools
LanguageTool
[typographical] ~663-~663: Two consecutive dots
Context: ... Partial ReferenceUsing the
^[N],^[N..M]syntax, You can reference the parent...(DOUBLE_PUNCTUATION)
666-666: Avoid using 'very'.The intensifier "very" is overused. Consider removing it for a stronger statement.
- you should add them very carefully. + you should add them carefully.Tools
LanguageTool
[style] ~666-~666: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...them in the future, you should add them very carefully.SCSS like Syntax:
.fo... (EN_WEAK_ADJECTIVE) </blockquote></details> </details> --- `569-569`: **Avoid using emphasis as a heading.** The emphasis is used instead of a heading. Consider using a proper heading style. ```diff - **Nesting for performance** + ### Nesting for performanceTools
Markdownlint
569-569: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
text/002-css-rules.md (10)
1-6: Clarify the relation to SCSS and Stitches.The summary mentions partial coverage of SCSS mixins and Stitches variants. Consider clarifying how this new approach compares or integrates with these technologies.
17-61: Ensure consistency in code examples.The code examples use different styles for defining CSS classes. Ensure consistency in the examples to improve readability.
79-140: Clarify the role of functions in dynamic styling.The section introduces functions in styling but could benefit from a clearer explanation of how they enhance dynamic styling.
142-179: Enhance clarity in SCSS to JavaScript comparison.The comparison between SCSS mixins and JavaScript functions could be more explicit to help readers understand the transition.
184-221: Clarify the benefits of using variants.The section could benefit from a clearer explanation of the advantages of using variants in styling.
251-258: Simplify the explanation of BEM block expression.The phrase "by the use of" is wordy. Consider simplifying it for clarity.
- This can be expressed by the use of the generic `recipe`. + This can be expressed using the generic `recipe`.Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
817-823: Clarify the role of CSS Variables.The section mentions using CSS Variables. Consider providing a brief explanation of their role in the new styling approach.
825-846: Clarify the limitations of conditional styling.The section could benefit from a clearer explanation of why conditional styling with props is not available and how variants can be used instead.
943-946: Clarify the challenges in implementation.The section could benefit from a clearer explanation of the challenges in implementing the new features.
948-986: Expand on future possibilities.Consider providing more detailed examples or explanations for the future possibilities mentioned.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILLFiles selected for processing (8)
- .github/workflows/fast-forward.yml (1 hunks)
- .github/workflows/pull_request.yml (1 hunks)
- 000-template.md (1 hunks)
- LICENSE (1 hunks)
- README.md (1 hunks)
- text/000-css-literals.md (1 hunks)
- text/001-css-nesting.md (1 hunks)
- text/002-css-rules.md (1 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/fast-forward.yml
- .github/workflows/pull_request.yml
- LICENSE
- README.md
Additional context used
LanguageTool
000-template.md
[grammar] ~18-~18: You can use the subjunctive mood in this context.
Context: ...nationExplain the proposal as if it was already included in the CSS-in-JS libra...
(SUBJUNCTIVE_MOOD)
[uncategorized] ~18-~18: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lready included in the CSS-in-JS library and you were teaching it to another CSS-in-...(COMMA_COMPOUND_SENTENCE)
[style] ~47-~47: ‘in the space of’ might be wordy. Consider a shorter alternative.
Context: ...atives
- Why is this design the best in the space of possible designs?
- What other designs...
(EN_WORDINESS_PREMIUM_IN_THE_SPACE_OF)
[uncategorized] ~48-~48: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... What other designs have been considered and what is the rationale for not choosing ...(COMMA_COMPOUND_SENTENCE_2)
[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...f this feature before stabilization?
- What related issues do you consider out of s...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[uncategorized] ~62-~62: Possible missing comma found.
Context: ...n and evolution of your proposal would
be and how it would affect the library and...(AI_HYDRA_LEO_MISSING_COMMA)
[misspelling] ~67-~67: This word is normally spelled as one.
Context: ...ap for the project
and of the relevant sub-team.This is also a good place to "dump ...
(EN_COMPOUNDS_SUB_TEAM)
text/000-css-literals.md
[uncategorized] ~418-~418: Possible missing article found.
Context: ...ble inline.
fontFamily$is used as special case of theMerge Valuesrule.**C...
(AI_HYDRA_LEO_MISSING_A)
[style] ~527-~527: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...erence-level explanationIf you make a lot of things top level, it can become difficu...
(A_LOT_OF)
[style] ~565-~565: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...e.
kebab-caseis not available and in many cases must be represented using a string of v...(IN_MANY_STYLE_CASES)
[style] ~646-~646: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...roup/awesome-css#preprocessors-pill) is a very big competitor and substitute.In the CS...
(EN_WEAK_ADJECTIVE)
text/001-css-nesting.md
[uncategorized] ~67-~67: This expression is usually spelled with a hyphen.
Context: ...Uppercase it to distinguish it from
Property based condition.
[Vendor Prefixes](./000-...(BASED_HYPHEN)
[uncategorized] ~99-~99: This expression is usually spelled with a hyphen.
Context: ... transition-delay: 2s;
}## 3. Property based condition Inspired by the [Panda CSS](... (BASED_HYPHEN) --- [uncategorized] ~339-~339: This expression is usually spelled with a hyphen. Context: ...ue; } }It can be used with
Property based condition.Code:
(BASED_HYPHEN) --- [uncategorized] ~537-~537: Loose punctuation mark. Context: ... `@layer`) and selectors. 1. `@media`: Apply styles based on screen size or de... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~539-~539: Loose punctuation mark. Context: ...pecific features first. 3. `@container`: Apply styles based on the size or chara... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~540-~540: Loose punctuation mark. Context: ...cs of a specific container. 4. `@layer`: Define the priority of the style. 5. s... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~555-~555: Loose punctuation mark. Context: ...specific benchmarks yet***. 1. `@layer`: It defines the entire style sheet struc... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~556-~556: Loose punctuation mark. Context: ...s on the outermost part. 2. `@supports`: If it's on top, browser can avoid unnec... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~556-~556: You might be missing the article “the” here. Context: ... part. 2. `@supports`: If it's on top, browser can avoid unnecessary style calculation... (AI_EN_LECTOR_MISSING_DETERMINER_THE) --- [uncategorized] ~557-~557: Loose punctuation mark. Context: ...cessary style calculations. 3. `@media`: Apply styles based on screen size or de... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~558-~558: Loose punctuation mark. Context: ...device characteristics. 4. `@container`: It's in `@media` because it depends on ... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~571-~571: Loose punctuation mark. Context: ...t it is declared first. 2. `@container`: Since it is applied based on the condit... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~572-~572: Loose punctuation mark. Context: ...etter to be on the outside. 3. `@media`: It is recommended that styles branch ba... (UNLIKELY_OPENING_PUNCTUATION) --- [uncategorized] ~573-~573: Loose punctuation mark. Context: ...ns inside the container. 4. `@supports`: It checks for support of certain CSS fe... (UNLIKELY_OPENING_PUNCTUATION) --- [style] ~655-~655: To elevate your writing, try using a synonym here. Context: ...s duplication, but if abused, it can be hard to know the context. # Rationale and... (HARD_TO) --- [typographical] ~663-~663: Two consecutive dots Context: ... Partial Reference Using the `^[N]`, `^[N..M]` syntax, You can reference the parent... (DOUBLE_PUNCTUATION) --- [style] ~666-~666: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ...them in the future, you should add them very carefully. **SCSS like Syntax:** ```scss .fo... (EN_WEAK_ADJECTIVE) </blockquote></details> <details> <summary>text/002-css-rules.md</summary><blockquote> [style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak... (EN_WEAK_ADJECTIVE) --- [style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o... (EN_WEAK_ADJECTIVE) --- [style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative. Context: ...gful on its own. This can be expressed by the use of the generic `recipe`. ```typescript co... (EN_WORDINESS_PREMIUM_BY_THE_USE_OF) --- [style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart. Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove... (IN_MANY_STYLE_CASES) --- [style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb. Context: ... // common variants } }); ``` It seems also awkward to use `true` even when using. ... (ALSO_PLACEMENT) --- [style] ~939-~939: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand... (EN_WEAK_ADJECTIVE) </blockquote></details> </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> <details> <summary>000-template.md</summary><blockquote> 4-4: Unused link or image reference definition: "summary" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 9-9: Unused link or image reference definition: "motivation" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 16-16: Unused link or image reference definition: "guide-level-explanation" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 29-29: Unused link or image reference definition: "reference-level-explanation" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 40-40: Unused link or image reference definition: "drawbacks" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 45-45: Unused link or image reference definition: "rationale-and-alternatives" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 53-53: Unused link or image reference definition: "unresolved-questions" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) --- 60-60: Unused link or image reference definition: "future-possibilities" Link and image reference definitions should be needed (MD053, link-image-reference-definitions) </blockquote></details> <details> <summary>text/000-css-literals.md</summary><blockquote> 523-523: null Spaces inside code span elements (MD038, no-space-in-code) --- 523-523: null Spaces inside code span elements (MD038, no-space-in-code) </blockquote></details> <details> <summary>text/001-css-nesting.md</summary><blockquote> 569-569: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </blockquote></details> <details> <summary>text/002-css-rules.md</summary><blockquote> 678-678: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </blockquote></details> </blockquote></details> </details> <details> <summary>Additional comments not posted (2)</summary><blockquote> <details> <summary>text/002-css-rules.md (2)</summary><blockquote> `331-335`: **Add missing subject for clarity.** Consider adding "It" at the beginning of the sentence for completeness. --- `937-939`: **Correct grammatical error in variants feature description.** Change "a very powerful variants feature" to "very powerful variants feature" for grammatical correctness. <details> <summary>Tools</summary> <details> <summary>LanguageTool</summary><blockquote> [style] ~939-~939: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand... (EN_WEAK_ADJECTIVE) </blockquote></details> </details> </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 65949b26552d4d5a85f4e8b6487381e6e391a2b8 (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 by @black7375. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit a7006a1b921c6f3c2cf97913358dca6a6ba50b6f (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default VariantsIt is possible to fast forward |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit a7006a1b921c6f3c2cf97913358dca6a6ba50b6f (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (1)
text/002-css-rules.md (1)
5-6: Enhance the summary with examples.Consider providing a brief example or additional context to illustrate how props are used in styling, similar to SCSS mixins or Stitches variants.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- text/002-css-rules.md (1 hunks)
Additional context used
LanguageTool
text/002-css-rules.md
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
[style] ~939-~939: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand...(EN_WEAK_ADJECTIVE)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (7)
text/002-css-rules.md (7)
14-14: Correct typo in Vanilla Extract reference.There is a typo in "Vaniila extract's recipes." It should be "Vanilla Extract's recipes."
66-76: Fix Typographical Error in Compiled CSS Example.There is a repeated class name in the compiled CSS example. Ensure each class has a unique name.
144-179: LGTM!The comparison between SCSS mixins and JavaScript functions is clear and well-explained.
249-249: Correct Grammatical Error.Change "Variants is" to "Variants are" for grammatical correctness.
253-329: LGTM!The explanation of implementing BEM methodology using recipes is clear and aligns with BEM principles.
Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
335-335: Add Missing Subject.Consider adding "It" at the beginning of the sentence for completeness.
948-986: LGTM!The section on future possibilities is forward-looking and provides useful references.
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit a7006a1b921c6f3c2cf97913358dca6a6ba50b6f (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Aug 11 21:29:32 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 29e1b103c9e85e8d37209132c35b827e2c3db703 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sat Aug 17 14:29:37 2024 +0900
Add: Default VariantsIt is possible to fast forward |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 29e1b103c9e85e8d37209132c35b827e2c3db703 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sat Aug 17 14:29:37 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range, codebase verification and nitpick comments (1)
text/002-css-rules.md (1)
257-257: Simplify Wordy Phrase.The phrase "by the use of" might be wordy. Consider using "using" for simplicity.
- This can be expressed by the use of the generic `recipe`. + This can be expressed using the generic `recipe`.Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...ul on its own.This can be expressed by the use of the generic
recipe.... (EN_WORDINESS_PREMIUM_BY_THE_USE_OF) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between a7006a1b921c6f3c2cf97913358dca6a6ba50b6f and 29e1b103c9e85e8d37209132c35b827e2c3db703. </details> <details> <summary>Files selected for processing (1)</summary> * text/002-css-rules.md (1 hunks) </details> <details> <summary>Additional context used</summary> <details> <summary>LanguageTool</summary><blockquote> <details> <summary>text/002-css-rules.md</summary><blockquote> [style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ...uare(100, 4)]);Control flow is very powerful, but it's also very easy to make mistak...
(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes.
It leaves the way ...(EN_WEAK_ADJECTIVE)
[uncategorized] ~187-~187: You might be missing the article “the” here.
Context: ...akes some control flows declarative.Vanilla extract, which this project is based on...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...ul on its own.This can be expressed by the use of the generic
recipe.... (EN_WORDINESS_PREMIUM_BY_THE_USE_OF) --- [uncategorized] ~341-~341: The grammatical number of this noun doesn’t look right. Consider replacing it. Context: ...h `cssVariant` and to go beyond variant feature like props. Inspired by the [Fela ru... (AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER) --- [style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart. Context: ... and should be avoided. Fortunately, in many cases, props are used as is. You can remov... (IN_MANY_STYLE_CASES) --- [style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb. Context: ...// common variants } });It seems also awkward to use
trueeven when using.
...(ALSO_PLACEMENT)
[uncategorized] ~716-~716: A determiner appears to be missing. Consider inserting it.
Context: ...16px"
}
}
]
});First method is original method in stitches's... (AI_EN_LECTOR_MISSING_DETERMINER) --- [uncategorized] ~717-~717: You might be missing the article “the” here. Context: ... } ] });First method is original method in stitches's compound variants,...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~717-~717: You might be missing the article “a” here.
Context: ...es's compound variants, and it is still good way for it.
So we keep it.And se...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~720-~720: You might be missing the article “the” here.
Context: ...od way for it.
So we keep it.And second method we present will provide a more c...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~843-~843: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...in the future when functionalrules()is implemented.Fixed set of styles
...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[style] ~953-~953: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...lternativesPandaCSS is implementing very powerful variants feature([Recipes](https://pand...
(EN_WEAK_ADJECTIVE)
[uncategorized] ~1000-~1000: The preposition “of” seems more likely in this position.
Context: ... Atomic StylesThis library was born for the combination of
Atomic CSSand `CS...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (7)
text/002-css-rules.md (7)
17-61: LGTM!The section on composition is clear and well-structured.
142-179: LGTM!The section on mixins is clear and effectively demonstrates the translation from SCSS to JavaScript.
249-249: Correct Grammatical Error.Change "Variants is" to "Variants are" for grammatical correctness.
335-335: Add Missing Subject.Consider adding "It" at the beginning of the sentence for completeness.
727-727: Fix Typographical Error in Compiled CSS Example.Correct the repeated typo "font-szie" to "font-size."
746-771: LGTM!The section on default variants is clear and aligns well with existing methods.
953-953: Correct Grammatical Error.Change "a very powerful variants feature" to "very powerful variants feature" for grammatical correctness.
Tools
LanguageTool
[style] ~953-~953: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...lternativesPandaCSS is implementing very powerful variants feature([Recipes](https://pand...
(EN_WEAK_ADJECTIVE)
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 29e1b103c9e85e8d37209132c35b827e2c3db703 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sat Aug 17 14:29:37 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 4bb69fc75f2cef667aa4be9b9d41ea5571c85c00 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 15:45:55 2024 +0900
Add: Default VariantsIt is possible to fast forward |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 4bb69fc75f2cef667aa4be9b9d41ea5571c85c00 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 15:45:55 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- text/002-css-rules.md (1 hunks)
Additional context used
LanguageTool
text/002-css-rules.md
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
[style] ~953-~953: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand...(EN_WEAK_ADJECTIVE)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (10)
text/002-css-rules.md (10)
3-6: Section Approved: SummaryThe summary is clear and provides a concise overview of the styling concepts being introduced.
8-16: Section Approved: MotivationThe motivations for the styling approach are well-articulated and relevant to the project's goals.
17-77: Section Approved: CompositionThe explanation and examples of composition using CSS literals are clear and informative.
79-140: Section Approved: Dynamic StylingThe section effectively explains dynamic styling with clear examples.
142-179: Section Approved: MixinThe comparison of SCSS mixins with JavaScript implementations is clear and accurate.
184-221: Section Approved: VariantsThe explanation of variants is clear, and the examples are well-chosen.
331-342: Section Approved: Guide-level explanationThe guide-level explanation is clear and provides useful guidance on the API usage.
575-637: Section Approved: Toggle VariantsThe introduction of a new syntax for toggle variants is clear, and the examples are effective.
Tools
LanguageTool
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
639-744: Section Approved: Compound VariantsThe discussion of compound variants is clear, and the examples are helpful.
Tools
Markdownlint
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
746-771: Section Approved: Default VariantsThe explanation of default variants is clear, and the examples are appropriate.
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 4bb69fc75f2cef667aa4be9b9d41ea5571c85c00 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 15:45:55 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit a028e2ee20af27360c1b0f8620d423b550aaab38 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 22309af4b7a7242996b1555957fdd0893c8cc557 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Wed Aug 21 23:00:43 2024 +0900
Add: Draft of RulesVariantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- text/002-css-rules.md (1 hunks)
Additional context used
LanguageTool
text/002-css-rules.md
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
[style] ~779-~779: The word ‘gonna’ is informal.
Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com...(GONNA)
[grammar] ~819-~819: The past participle is required after “could be”.
Context: ...s/) for code style for now. It could be change to [sub functions](https://github.com/m...(BE_VBP_IN)
[style] ~1046-~1046: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand...(EN_WEAK_ADJECTIVE)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Jeong-jj
changed the title
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 22309af4b7a7242996b1555957fdd0893c8cc557 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Wed Aug 21 23:00:43 2024 +0900
Add: Draft of RulesVariantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 22309af4b7a7242996b1555957fdd0893c8cc557 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Wed Aug 21 23:00:43 2024 +0900
Add: Draft of RulesVariantsIt is possible to fast forward |
|
Triggered from #10 by @Jeong-jj. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit cee3fcaeec5216e6776abc3965325f56579fd91c (pull_request/css-rules)
Author: JeongJun <[email protected]>
Date: Sun Sep 1 17:04:11 2024 +0900
Add: Drafit of RulesVariantsIt is possible to fast forward |
black7375
changed the title
There are two suggestions of compound variants
|
Triggered from #10 by @black7375. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit af92a2d7fb0e6f931e4e2c495336d5fa391734c3 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants
Add: Composition in CSS Rules
Add: Drafit of RulesVariantsIt is possible to fast forward |
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit af92a2d7fb0e6f931e4e2c495336d5fa391734c3 (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants
Add: Composition in CSS Rules
Add: Drafit of RulesVariantscurl: (3) bad range in URL position 81: |
|
Triggered from #10 by @black7375. Checking if we can fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants, Composition, RulesVariantsIt is possible to fast forward |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (7)
text/002-css-rules.md (7)
181-182: Suggestion: Replace overused intensifier "very" with an alternative.Consider replacing the overused intensifier "very" in the phrases "very powerful" and "very easy" with less frequent alternatives to improve the writing style and set it apart.
- Control flow is very powerful, but it's also very easy to make mistakes. + Control flow is extremely powerful, but it's also highly prone to errors.Tools
LanguageTool
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
257-258: Suggestion: Replace wordy phrase "by the use of" with a shorter alternative.Consider replacing the wordy phrase "by the use of" with a shorter alternative to make the writing more concise.
- This can be expressed by the use of the generic `recipe`. + This can be expressed using the generic `recipe`.Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
397-399: Suggestion: Replace frequently used phrase "in many cases" with a less frequent alternative.Consider replacing the frequently used phrase "in many cases" with a less frequent alternative to improve the writing style and set it apart.
- Fortunately, in many cases, props are used as is. + Fortunately, in numerous scenarios, props are used as is.Tools
LanguageTool
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
612-615: Suggestion: Move "also" before the verb to improve writing flow.Consider moving "also" before the verb to make the writing flow more naturally.
- It seems also awkward to use `true` even when using. + It also seems awkward to use `true` even when using.Tools
LanguageTool
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
779-779: Suggestion: Replace informal word "gonna" with a formal alternative.Consider replacing the informal word "gonna" with a formal alternative to make the writing more professional.
- And It gonna inherit base rules like [Stitches's Composing Components](https://stitches.dev/docs/composing-components). + And it will inherit base rules like [Stitches's Composing Components](https://stitches.dev/docs/composing-components).Tools
LanguageTool
[style] ~779-~779: The word ‘gonna’ is informal.
Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com...(GONNA)
849-849: Suggestion: Use past participle after "could be" for grammatical correctness.Consider using the past participle after "could be" to make the sentence grammatically correct.
- It could be change to [sub functions](https://github.com/mincho-js/mincho/issues/59). + It could be changed to [sub functions](https://github.com/mincho-js/mincho/issues/59).Tools
LanguageTool
[grammar] ~849-~849: The past participle is required after “could be”.
Context: ...s/) for code style for now. It could be change to [sub functions](https://github.com/m...(BE_VBP_IN)
1093-1094: Suggestion: Replace overused intensifier "very" with an alternative.Consider replacing the overused intensifier "very" in the phrase "very powerful" with a less frequent alternative to improve the writing style and set it apart.
- PandaCSS is implementing very powerful variants feature([Recipes](https://panda-css.com/docs/concepts/recipes), [Slot Recipes](https://panda-css.com/docs/concepts/slot-recipes)). + PandaCSS is implementing an extremely powerful variants feature([Recipes](https://panda-css.com/docs/concepts/recipes), [Slot Recipes](https://panda-css.com/docs/concepts/slot-recipes)).Tools
LanguageTool
[style] ~1093-~1093: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand...(EN_WEAK_ADJECTIVE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- text/000-css-literals.md (1 hunks)
- text/002-css-rules.md (1 hunks)
Additional context used
LanguageTool
text/002-css-rules.md
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
[style] ~779-~779: The word ‘gonna’ is informal.
Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com...(GONNA)
[grammar] ~849-~849: The past participle is required after “could be”.
Context: ...s/) for code style for now. It could be change to [sub functions](https://github.com/m...(BE_VBP_IN)
[style] ~1093-~1093: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand...(EN_WEAK_ADJECTIVE)
Markdownlint
text/002-css-rules.md
678-678: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
840-840: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (1)
text/000-css-literals.md (1)
509-513: LGTM!The changes to the compiled CSS example, renaming the class names to reflect a primary and secondary distinction, are approved. The renaming enhances clarity and specificity in the CSS structure.
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants, Composition, RulesVariantscurl: (3) bad range in URL position 81: |
1 similar comment
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants, Composition, RulesVariantscurl: (3) bad range in URL position 81: |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (7)
text/002-css-rules.md (7)
142-183: LGTM! Just a minor suggestion.The "Mixin" subsection provides a good explanation of how mixins can be implemented in JavaScript using composition and merging. The examples effectively demonstrate the concept, and the point about the power and potential pitfalls of control flow is valid.
Consider rephrasing the sentence "Control flow is very powerful, but it's also very easy to make mistakes." to avoid overusing the word "very". For example:
- Control flow is very powerful, but it's also very easy to make mistakes. + Control flow is powerful but can easily lead to mistakes.Tools
LanguageTool
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak...(EN_WEAK_ADJECTIVE)
[style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o...(EN_WEAK_ADJECTIVE)
252-310: LGTM! Just a minor suggestion.The "BEM" subsection provides a clear explanation of how BEM concepts can be mapped to the
recipefunction. The code examples effectively demonstrate the usage of BEM withrecipe.Consider rephrasing the sentence "This can be expressed by the use of the generic
recipe." to be more concise. For example:- This can be expressed by the use of the generic `recipe`. + This can be expressed using the generic `recipe`.Tools
LanguageTool
[style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative.
Context: ...gful on its own. This can be expressed by the use of the genericrecipe. ```typescript co...(EN_WORDINESS_PREMIUM_BY_THE_USE_OF)
397-398: Consider rephrasing the overused phrase "in many cases".The phrase "in many cases" is used quite frequently. Consider using a less frequent alternative to set your writing apart. For example:
- Fortunately, in many cases, props are used as is. + Fortunately, props are often used as is.Tools
LanguageTool
[style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart.
Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove...(IN_MANY_STYLE_CASES)
612-613: Move the word "also" before the verb.To make your writing flow more naturally, try moving "also" before the verb. For example:
- It seems also awkward to use `true` even when using. + It also seems awkward to use `true` even when using.Tools
LanguageTool
[style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ... // common variants } }); ``` It seems also awkward to usetrueeven when using. ...(ALSO_PLACEMENT)
778-779: Replace the informal word "gonna".The word "gonna" is informal. Consider replacing it with "will". For example:
- And It gonna inherit base rules like [Stitches's Composing Components](https://stitches.dev/docs/composing-components). + And it will inherit base rules like [Stitches's Composing Components](https://stitches.dev/docs/composing-components).Tools
LanguageTool
[style] ~779-~779: The word ‘gonna’ is informal.
Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com...(GONNA)
972-979: LGTM! Just a minor grammatical correction.The "Reference-level explanation" section provides relevant references for the implementation of the
rulesAPI. The mention of using CSS Variables for thepropsfeature is a good point.There is a grammatical error in the sentence "It could be change to sub functions.". It should be corrected as follows:
- It could be change to [sub functions](https://github.com/mincho-js/mincho/issues/59). + It could be changed to [sub functions](https://github.com/mincho-js/mincho/issues/59).
980-1141: LGTM! Just a minor suggestion.The "Drawbacks", "Rationale and alternatives", "Unresolved questions", and "Future possibilities" sections provide a balanced discussion of the drawbacks, alternatives, unresolved questions, and future possibilities related to the
rulesAPI. The points raised are valid and well-explained.Consider rephrasing the sentence "PandaCSS is implementing very powerful variants feature(Recipes, Slot Recipes)." to avoid overusing the phrase "very powerful". For example:
- PandaCSS is implementing very powerful variants feature([Recipes](https://panda-css.com/docs/concepts/recipes), [ <details> <summary>Tools</summary> <details> <summary>LanguageTool</summary><blockquote> [style] ~1093-~1093: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand... (EN_WEAK_ADJECTIVE) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between af92a2d7fb0e6f931e4e2c495336d5fa391734c3 and 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b. </details> <details> <summary>Files selected for processing (2)</summary> * text/000-css-literals.md (1 hunks) * text/002-css-rules.md (1 hunks) </details> <details> <summary>Files skipped from review as they are similar to previous changes (1)</summary> * text/000-css-literals.md </details> <details> <summary>Additional context used</summary> <details> <summary>LanguageTool</summary><blockquote> <details> <summary>text/002-css-rules.md</summary><blockquote> [style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... square(100, 4)]); ``` Control flow is very powerful, but it's also very easy to make mistak... (EN_WEAK_ADJECTIVE) --- [style] ~181-~181: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ...ol flow is very powerful, but it's also very easy to make mistakes. It leaves the way o... (EN_WEAK_ADJECTIVE) --- [style] ~257-~257: ‘by the use of’ might be wordy. Consider a shorter alternative. Context: ...gful on its own. This can be expressed by the use of the generic `recipe`. ```typescript co... (EN_WORDINESS_PREMIUM_BY_THE_USE_OF) --- [style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart. Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove... (IN_MANY_STYLE_CASES) --- [style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb. Context: ... // common variants } }); ``` It seems also awkward to use `true` even when using. ... (ALSO_PLACEMENT) --- [style] ~779-~779: The word ‘gonna’ is informal. Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com... (GONNA) --- [grammar] ~849-~849: The past participle is required after “could be”. Context: ...s/) for code style for now. It could be change to [sub functions](https://github.com/m... (BE_VBP_IN) --- [style] ~1093-~1093: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. Context: ... alternatives PandaCSS is implementing very powerful variants feature([Recipes](https://pand... (EN_WEAK_ADJECTIVE) </blockquote></details> </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> <details> <summary>text/002-css-rules.md</summary><blockquote> 678-678: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) --- 840-840: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </blockquote></details> </blockquote></details> </details> <details> <summary>Additional comments not posted (6)</summary><blockquote> <details> <summary>text/002-css-rules.md (6)</summary><blockquote> `3-7`: **LGTM!** The "Summary" section provides a clear and concise overview of the new "CSS rules" feature. --- `8-16`: **LGTM!** The "Motivation" section effectively lists the key reasons for introducing the "CSS rules" feature. --- `17-77`: **LGTM!** The "Composition" subsection provides a clear explanation of how the `css` function and `clsx` library can be used for class composition. The code examples effectively illustrate the concepts. --- `79-140`: **LGTM!** The "Dynamic Styling" subsection effectively explains the need for dynamic styling and proposes a solution using style functions. The code examples demonstrate the concept well, and the acknowledgment of potential confusion and the need for separation is a good point. --- `184-248`: **LGTM!** The "Variants" subsection provides a good introduction to the concept of variants and its implementation in Vanilla Extract using the `recipe` function. The code examples effectively demonstrate the usage of variants and compound variants. --- `331-971`: **LGTM overall! Just a few minor suggestions.** The "Guide-level explanation" section provides a comprehensive guide on using the `rules` API. The explanations are clear, and the code examples effectively demonstrate the various aspects of the API. <details> <summary>Tools</summary> <details> <summary>LanguageTool</summary><blockquote> [style] ~397-~397: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart. Context: ...on and should be avoided. Fortunately, in many cases, props are used as is. You can remove... (IN_MANY_STYLE_CASES) --- [style] ~612-~612: To make your writing flow more naturally, try moving ‘also’ before the verb. Context: ... // common variants } }); ``` It seems also awkward to use `true` even when using. ... (ALSO_PLACEMENT) --- [style] ~779-~779: The word ‘gonna’ is informal. Context: ...So we maintain this basically. And It gonna inherit base rules like [Stitches's Com... (GONNA) --- [grammar] ~849-~849: The past participle is required after “could be”. Context: ...s/) for code style for now. It could be change to [sub functions](https://github.com/m... (BE_VBP_IN) </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> 678-678: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) --- 840-840: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </blockquote></details> </details> </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
Triggered from #10 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants, Composition, RulesVariantscurl: (3) bad range in URL position 81: |
|
/fast-forward |
|
Triggered from #10 (comment) by @black7375. Trying to fast forward Target branch ( commit 73a21ff90a4208be8005daf4e9c4695839a4c408 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Sat Jul 20 15:32:37 2024 +0900
Add: Templates from Rust RFC
Refer: https://github.com/rust-lang/rfcs/blob/master/0000-template.mdPull request ( commit 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b (pull_request/css-rules)
Author: JeongJun Jo <[email protected]>
Date: Sun Aug 18 17:16:08 2024 +0900
Add: Default Variants, Composition, RulesVariantsFast forwarding $ git push origin 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b:main
To https://github.com/mincho-js/working-group.git
73a21ff..5d8dd5d 5d8dd5d552dc59bf36dcb8ad8eb971494786db4b -> main |
I drafted
Compound VariantsandDefault Variants.At the first I suggested two options about
Compound Variants, but I chose one after we discussed it.Note.
I made mistake about commit log. I fixed it, but log time line is changed a little bit.
c19817f was originally logged in July 3rd, but log time have been changed to today. Im sorry about this.
cc. @black7375
Summary by CodeRabbit
New Features
Documentation
Chores