Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not break if a day only contains a single line. #11

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Do not break if a day only contains a single line. #11

merged 3 commits into from
Dec 21, 2023

Conversation

icemac
Copy link
Collaborator

@icemac icemac commented Dec 20, 2023

Render a better error message if an entry cannot be parsed.

@icemac
Do not break if a day only contains a single line.
9a269e5 
Render a better error message if an entry cannot be parsed.
@icemac icemac added the enhancement New feature or request label Dec 20, 2023
@icemac icemac requested a review from sallner December 20, 2023 07:11
@icemac icemac self-assigned this Dec 20, 2023
@icemac icemac enabled auto-merge (squash) December 20, 2023 07:13
sallner
sallner approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions from reading the code, but did not try it out by myself.

gtimelog2tick.py Outdated Show resolved Hide resolved
tests.py Outdated Show resolved Hide resolved
tests.py Outdated Show resolved Hide resolved
icemac and others added 2 commits December 20, 2023 13:26
@icemac @sallner
Apply suggestions from code review
f76f390 
Co-authored-by: Steffen Allner <[email protected]>
@icemac
Refactor evaluation of entry message to be lazy.
5c3d819 
Now a worklog entry can be created and the hours of it accessed before parsing
the message into a task.
@icemac icemac requested a review from sallner December 21, 2023 09:42
@icemac icemac merged commit 4930fd0 into master Dec 21, 2023
2 checks passed
@icemac icemac deleted the handle-parse-errors branch December 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallner sallner Awaiting requested review from sallner

Assignees

@icemac icemac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @sallner