Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minetest config ui #184

Merged
merged 19 commits into from
Aug 30, 2023
Merged

minetest config ui #184

merged 19 commits into from
Aug 30, 2023

Conversation

BuckarooBanzay
Copy link
Member

@BuckarooBanzay BuckarooBanzay commented Aug 18, 2023 •
edited
Loading

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Aug 18, 2023
@coveralls
Copy link

coveralls commented Aug 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6028244708

  • 92 of 251 (36.65%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 41.352%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minetestconfig/settingtype_parser.go 10 15 66.67%
minetestconfig/setting.go 62 79 78.48%
minetestconfig/config.go 7 26 26.92%
web/mtconfig.go 0 118 0.0%
Totals Coverage Status
Change from base Build 5902544561: -0.7%
Covered Lines: 1633
Relevant Lines: 3949
💛 - Coveralls

@BuckarooBanzay BuckarooBanzay marked this pull request as ready for review August 30, 2023 17:42
@BuckarooBanzay BuckarooBanzay merged commit 2714dec into master Aug 30, 2023
3 checks passed
@BuckarooBanzay BuckarooBanzay deleted the mtconfig branch September 13, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuckarooBanzay @coveralls