Allow full error trace in Nunjucks #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a global function in a template throws an error, we don’t see the full trace of the error, which makes diagnosing issues really hard. This makes use of the [undocumented dev argument](mozilla/nunjucks#1430) which allows us to see the cause of the error in our logs and in Sentry. I’ve had to extend the nunjucks types to allow for this option to be set, as it’s not in the type definition in `DefinitelyTyped`. However, I’ve [opened a PR to add this](DefinitelyTyped/DefinitelyTyped#63968)
pezholio
force-pushed
the
allow-full-trace-to-be-seen-in-nunjucks
branch
from
614b987 to
8eed08b
Compare
|
Is it worth adding this to the template? or maybe we should wait for the DefinitelyTyped PR to merge |
richpjames
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a global function in a template throws an error, we don’t see the full trace of the error, which makes diagnosing issues really hard.
This makes use of the undocumented dev argument which allows us to see the cause of the error in our logs and in Sentry.
I’ve had to extend the nunjucks types to allow for this option to be set, as it’s not in the type definition in
DefinitelyTyped. However, I’ve opened a PR to add this