Replace AccountsBalanceTracker with accounting deltas
#1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
chainstate/constraints-value-accumulator/src/constraints_accumulator.rs
Outdated
Show resolved
Hide resolved
| @@ -113,6 +121,34 @@ impl<'a> PoSAccountingView for PoSAccountingAdapterToCheckFees<'a> { | |||
| } | |||
| } | |||
|
|
|||
| struct StubTokensAccounting; | |||
There was a problem hiding this comment.
I thought we used the word "Mock" instead of "Stub"... it's a matter of convention.
There was a problem hiding this comment.
Idk it's actually a stub with hardcoded state to satisfy function signature. It doesn't have any logic or expectation as mocks
TheQuantumPhysicist
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountsBalanceTrackerwas used to check if multiple account spend in a single tx won't underflow the balance. To avoid duplicating code when adding support for Orders I use Deltas now. They already implement all the constraint check and are easily reusable for the job.