Decrease max_future_block_time_offset
#1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
Comment on lines
-609
to
-610
| let last_header = headers.last().expect("Headers shouldn't be empty"); | ||
| self.wait_for_clock_diff(last_header.timestamp()).await; |
There was a problem hiding this comment.
Why removing this? Please be careful with such radical changes without studying the consequences.
There was a problem hiding this comment.
I moved it to the line 644 where the block height is available
p2p/src/sync/peer/block_manager.rs
Outdated
| let last_header = headers.last().expect("Headers shouldn't be empty"); | ||
| self.wait_for_clock_diff( | ||
| last_header.timestamp(), | ||
| first_header_prev_block_index.block_height(), |
There was a problem hiding this comment.
Shouldn't it be the height of the last header? (which is the height of the first header plus the number of headers minus one).
P.S. perhaps we should call max_future_block_time_offset for all heights in this range and choose the bigger.
azarovh
force-pushed
the
decrease_max_future_offset
branch
from
d98ab17 to
49e55f3
Compare
ImplOfAnImpl
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.