Minor gui backend fixes #1855
Open
Minor gui backend fixes #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
ImplOfAnImpl and
OBorce
as code owners
ImplOfAnImpl
approved these changes
Dec 19, 2024
node-gui/backend/src/messages.rs
Outdated
Comment on lines
172
to
175
| pub fn to_json(&self, config: &ChainConfig) -> Result<serde_json::Value, BackendError> { | ||
| common::address::dehexify::to_dehexified_json(config, self.tx.transaction()) | ||
| .map_err(|e| BackendError::JsonError(e.to_string())) | ||
| } |
There was a problem hiding this comment.
I kind of missed the fact that Transaction is serializable. So now I'm wondering why SignedTransaction shouldn't be
There was a problem hiding this comment.
I don't know, my guess would be that we don't have a use case for serializing witnesses
OBorce
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactiontype to backend, which is a wrapper aroundSignedTransactionthat allows serialization/deserialization to hex and also methods to convert to text summary or json. Mainly to give UI flexibility and avoid deserializingSignedTransaction.