Logging initialization improvement #1857
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I replaced
init_logging_to
andinit_logging_with_env_var
with a single functioninit_logging_generic
that allows to specify an additional destination with separate filter and style settings.The "log_file" is now passed to
init_logging_generic
as this second destination. The level is "info" to keep the log size reasonable, though we may change it to debug too (but note that the simple "debug" will be too noisy for node-gui due to 3rd-party crates, so we'll need to filter them out)With this approach we