Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): サーバーを始動する前に他のサービスが始動するように #15103

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

This prevents an edge case where the server begins processing inbound API / AP requests before any of the chart / management daemons are ready, potentially leading to incorrect chart statistics.

チャートエンジン・キュープロセッサが起動する前にサーバーがリクエストを受け付ける可能性がある問題を修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

warriordog and others added 3 commits December 9, 2024 17:09
This prevents an edge case where the server begins processing inbound API / AP requests before any of the chart / management daemons are ready, potentially leading to incorrect chart statistics.
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.91%. Comparing base (e8bf628) to head (a736762).

Files with missing lines Patch % Lines
packages/backend/src/boot/common.ts 0.00% 9 Missing ⚠️
packages/backend/src/daemons/QueueStatsService.ts 0.00% 2 Missing ⚠️
packages/backend/src/daemons/ServerStatsService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15103      +/-   ##
===========================================
- Coverage    39.96%   38.91%   -1.06%     
===========================================
  Files         1563     1563              
  Lines       197752   197753       +1     
  Branches      3634     3327     -307     
===========================================
- Hits         79031    76953    -2078     
- Misses      118116   120189    +2073     
- Partials       605      611       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants