pin fewer futures, but add linter to make sure we don't backslide (#177)

* pin fewer futures, but add linter to make sure we don't backslide

* less stack, more heap!

Cargo.toml

@@ -18,6 +18,9 @@ repository = "https://github.com/mitmproxy/mitmproxy-rs"
 edition = "2021"
 rust-version = "1.80"  # MSRV
 
+[workspace.lints.clippy]
+large_futures = "deny"
+
 [package]
 name = "mitmproxy"
 license = "MIT"

mitmproxy-rs/Cargo.toml

@@ -8,6 +8,9 @@ edition.workspace = true
 rust-version.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 name = "mitmproxy_rs"
 crate-type = ["lib", "cdylib"]

mitmproxy-rs/src/server/base.rs

@@ -72,8 +72,8 @@ impl Server {
 
         // spawn tasks
         let mut tasks = JoinSet::new();
-        tasks.spawn(Box::pin(async move { packet_source_task.run().await }));
-        tasks.spawn(Box::pin(async move { py_task.run().await }));
+        tasks.spawn(async move { packet_source_task.run().await });
+        tasks.spawn(async move { py_task.run().await });
 
         let (shutdown_done_tx, shutdown_done_rx) = broadcast::channel(1);
         tokio::spawn(shutdown_task(tasks, shutdown_done_tx));

mitmproxy-rs/src/udp_client.rs

@@ -102,7 +102,7 @@ pub struct UdpClientTask {
 
 impl UdpClientTask {
     pub async fn run(mut self) -> Result<()> {
-        let mut udp_buf = [0; MAX_PACKET_SIZE];
+        let mut udp_buf = vec![0; MAX_PACKET_SIZE];
 
         // this here isn't perfect because we block the entire transport_commands_rx channel if we
         // cannot send (so we also block receiving new packets), but that's hopefully good enough.
@@ -114,7 +114,7 @@ impl UdpClientTask {
         loop {
             tokio::select! {
                 // wait for transport_events_tx channel capacity...
-                r = self.socket.recv(&mut udp_buf), if packet_tx.is_some() => {
+                r = self.socket.recv(udp_buf.as_mut_slice()), if packet_tx.is_some() => {
                     if remote_host_closed_conn(&r) {
                         continue;
                     }

mitmproxy-windows/redirector/Cargo.toml

@@ -8,6 +8,9 @@ edition.workspace = true
 rust-version.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [target.'cfg(windows)'.dependencies]

src/network/task.rs

@@ -45,7 +45,7 @@ pub fn add_network_layer(
         transport_commands_rx,
         shutdown,
     )?;
-    let h = tokio::spawn(Box::pin(async move { task.run().await }));
+    let h = tokio::spawn(async move { task.run().await });
     Ok((h, network_events_tx, network_commands_rx))
 }
 

wireguard-test-client/Cargo.toml

@@ -9,6 +9,9 @@ edition.workspace = true
 rust-version.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = "1.0.86"
 data-encoding = "2.6.0"