Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #176

Closed
wants to merge 1 commit into from
Closed

Update README.md #176

wants to merge 1 commit into from

Conversation

jamesev93
Copy link

Add missing step to get Development mode to work.

Add missing step to get Development mode to work.
@jamesev93
Copy link
Author

jamesev93 commented Sep 4, 2024

The __init__.py code checks for this file, but the docs dont indicate it is required.

@jamesev93
Copy link
Author

1c4a17a Is the change that removed the file, but didnt update the build steps.

@mhils
Copy link
Member

mhils commented Sep 6, 2024

Thanks for the PR, but this should absolutely not be necessary. pip install -e . typically creates that editable.marker file.

@jamesev93
Copy link
Author

I attempted to confirm that behavior, but was unable to replicate: For me, pip install -e . within the mitmproxy_rs/mitmproxy-windows/ does not generate an editable.marker file. It appears Hatch can be used to generate files with the hook plugin, however I can see no implementation details in the code for this. If the editable.marker file is generated when you pip install, then there is some implementation step I am missing and this can certainly be closed. I appreciate your time taken to comment.

@mhils
Copy link
Member

mhils commented Sep 9, 2024

(https://en.wikipedia.org/wiki/XY_problem applies here)

After running pip install -e ., things work for me as expected. Is that that not the case for you?

It may be the case that editable.marker is missing here, but nonetheless it should work.

@mhils mhils closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants