Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sysinfo on macos #201

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Bump sysinfo on macos #201

merged 1 commit into from
Dec 10, 2024

Conversation

errorxyz
Copy link
Contributor

@errorxyz errorxyz commented Dec 9, 2024

untested changes since I don't have access to a macOS machine

@errorxyz errorxyz marked this pull request as ready for review December 9, 2024 18:50
@errorxyz
Copy link
Contributor Author

errorxyz commented Dec 9, 2024

@mhils can you test this if changes look good to you?

@errorxyz
Copy link
Contributor Author

If the changes look good we can also reduce code repetition across linux_list.rs and macos_list.rs somewhere in the next PRs

Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 😃

@mhils mhils merged commit f577fd5 into mitmproxy:main Dec 10, 2024
18 checks passed
@errorxyz errorxyz deleted the macos branch December 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants