Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source based coverage for the extension #139

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Nov 8, 2024

Description of changes:

Kani's source coverage changes the output parsing logic and the highlighting components. This PR fixes the broken integration.

Call-outs:

Some screenshots:
Screenshot 2024-11-08 at 4 07 52 PM

Screenshot 2024-11-08 at 4 07 22 PM

Testing:

  • How is this change tested?
    Tested manually

  • Is this a refactor change?
    No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

return path.relative(workspaceFolder.uri.fsPath, fullPath);
}

// If not in a workspace, return the full path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be affected by model-checking/kani#2681?

const playbackCommand: string = `${kaniBinaryPath} --coverage -Z line-coverage --harness ${functionName}`;
// Run this command: cargo kani --coverage -Z source-coverage --harness verify_success
// to generate the source coverage output
const playbackCommand: string = `${kaniBinaryPath} --coverage -Z source-coverage --harness ${functionName}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/playbackCommand/coverageCommand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants