Add loop contracts and harness for BinaryHeap::sift_up
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinheping
changed the title
BinaryHeap::sift_up
tautschnig
reviewed
Oct 22, 2024
Would adding a |
tautschnig
reviewed
Oct 22, 2024
tautschnig
reviewed
Oct 22, 2024
celinval
reviewed
Oct 23, 2024
| unsafe fn sift_up(&mut self, start: usize, pos: usize) -> usize { | ||
| // Take out the value at `pos` and create a hole. | ||
| // SAFETY: The caller guarantees that pos < self.len() | ||
| let mut hole = unsafe { Hole::new(&mut self.data, pos) }; | ||
|
|
||
| #[cfg_attr(kani, kani::loop_invariant(hole.pos() <= pos))] |
There was a problem hiding this comment.
Can you please loop invariants to the safety crate for now and use that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proof is blocked as CBMC couldn't infer the loop modifies
hole.pos. We need to add support of loop modifies or improve CBMC's inference algorithm.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.