Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts and Harnesses for core::ptr::byte_offset_from #186

Merged
merged 13 commits into from
Dec 8, 2024
Merged

Contracts and Harnesses for core::ptr::byte_offset_from #186

merged 13 commits into from
Dec 8, 2024

Conversation

stogaru
Copy link

@stogaru stogaru commented Nov 26, 2024

Towards #76

Changes

  • Adds contracts for byte_offset_from.
  • Adds harnesses for the function verifying:
    • All integer types
    • Tuples (composite types)
    • Unit Type
    • Slices
  • Accomplishes this using a few macros.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@stogaru stogaru requested a review from a team as a code owner November 26, 2024 19:20
@stogaru
Copy link
Author

stogaru commented Nov 26, 2024

@feliperodri FYI

@tautschnig
Copy link
Member

@stogaru Please resolve conflicts.

@stogaru stogaru force-pushed the verify/ptr_const_byte_offset_from branch from fede9f0 to 6aacbb8 Compare November 28, 2024 07:07
@stogaru
Copy link
Author

stogaru commented Nov 28, 2024

@tautschnig Conflicts resolved

@stogaru stogaru removed their assignment Nov 28, 2024
tautschnig
tautschnig approved these changes Nov 28, 2024
View reviewed changes
library/core/src/ptr/mut_ptr.rs Outdated Show resolved Hide resolved
library/core/src/ptr/const_ptr.rs Show resolved Hide resolved
@stogaru stogaru force-pushed the verify/ptr_const_byte_offset_from branch from a9d2ff2 to dbf29ae Compare November 29, 2024 02:47
@stogaru stogaru mentioned this pull request Nov 29, 2024
Merged
@feliperodri feliperodri enabled auto-merge (squash) December 5, 2024 15:25
carolynzech
carolynzech reviewed Dec 5, 2024
View reviewed changes
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger merge workflow

@feliperodri feliperodri disabled auto-merge December 6, 2024 05:20
@feliperodri feliperodri enabled auto-merge (squash) December 6, 2024 05:20
feliperodri
feliperodri approved these changes Dec 7, 2024
View reviewed changes
Copy link

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger review

@stogaru stogaru mentioned this pull request Dec 8, 2024
Open
@feliperodri feliperodri merged commit 8a0d0ce into model-checking:main Dec 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynzech carolynzech carolynzech left review comments

@tautschnig tautschnig tautschnig approved these changes

@feliperodri feliperodri feliperodri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stogaru @tautschnig @feliperodri @carolynzech