Cstr verify safety contracts of unsafe functions strlen, from_bytes_with_nul_unchecked #193
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… . And stub for strlen + better documentation
rajathkotyal
changed the title
rajathkotyal
commented
Nov 28, 2024
rajathkotyal
commented
Dec 1, 2024
rajathkotyal
commented
Dec 1, 2024
rajathkotyal
commented
Dec 2, 2024
rajathkotyal
changed the title
celinval
reviewed
Dec 3, 2024
celinval
reviewed
Dec 3, 2024
tautschnig
approved these changes
Dec 3, 2024
|
@Yenyun035 can you fix the failing Rust tests and then we'll take a look if there's still issues? |
|
@carolynzech Sure. I annotated |
carolynzech
reviewed
Dec 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Towards #150 Similar PR Ref : #193 Annotates and verifies the safety contracts for the unsafe function : `from_ptr` - `core::ffi::c_str` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Yenyun035 <[email protected]> Co-authored-by: Yenyun035 <[email protected]>
|
@rajathkotyal Can I please ask you to resolve conflicts that arose with #204 now merged? |
|
@tautschnig Fixed. Thank you. |
tautschnig
approved these changes
Dec 11, 2024
carolynzech
changed the title
|
Thanks @Yenyun035 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #150
Annotates and verifies the safety contracts for the following unsafe functions:
from_bytes_with_nul_unchekedcore::ffi::c_strstrlencore::ffi::c_strBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.