add challenge for safety of primitive conversions #217
+141
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Dec 10, 2024
Co-authored-by: Michael Tautschnig <[email protected]>
cvick32
approved these changes
Dec 10, 2024
tautschnig
approved these changes
Dec 11, 2024
tautschnig
approved these changes
Dec 11, 2024
carolynzech
reviewed
Dec 11, 2024
|
|
||
| ### Success Criteria | ||
|
|
||
| #### Safety for Float to Int |
There was a problem hiding this comment.
It would be nice to also list all of the types that implement this float to int functionality, similarly to how you have the list in the section below for conversions, so that we're explicit about which proofs we expect.
Co-authored-by: Carolyn Zech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.