Remove unreliable signals very close to zero #4420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umerical approximations
casella
requested review from
AHaumer,
tobolar,
HansOlsson,
beutlich and
GallLeo
|
Once approved, this should be cherry-picked to maint/v4.1.0 as well. |
15 tasks
HansOlsson
reviewed
Jun 23, 2024
AHaumer
approved these changes
Jul 2, 2024
|
@HansOlsson the more I think of it the more I see you point. These signals are supposed to be near zero, and if we don't check they may (in principle) stray away. One could argue that they very likely can't do that without some of the non-zero components changing significantly, but at the end of the day this issue can be really fixed by just adding some sensible absolute tolerance to the CVS-compare tool. I'll keep this on hold for the time being. |
auto-merge was automatically disabled
July 3, 2024 06:39
Pull request was converted to draft
|
I converted it to a draft PR to reflect the previous comment and avoid accidental merging. |
beutlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These signals only depend on numerical approximations and CSV compare cannot evaluate them reliably because it lacks information about their magnitude (nominal attribute).