Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add align to img, p, and div & allow h1 to be centered #2231

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Add align to img, p, and div & allow h1 to be centered #2231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b51b041
Add align to img, p, and div
Minenash Aug 22, 2024
0145c5d
fixed issue from porting pr
Minenash Aug 22, 2024
6525c83
attempt to fix overflow of aligned imgs
Minenash Aug 22, 2024
14a8afb
Allow h1 to be centered
Minenash Aug 22, 2024
aaa168a
Excluded markdown-body from universal-card styling in components
Minenash Aug 22, 2024
46a2551
Fixed it in editor?
Minenash Aug 22, 2024
46f0083
undid previous attempt, did something simpler
Minenash Aug 22, 2024
07785da
Merge branch 'main' into markdown-align-for-img-p-div
Minenash Aug 22, 2024
0ef1fe1
Merge branch 'main' into markdown-align-for-img-p-div
Prospector Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/frontend/src/assets/styles/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@
align-items: center;
}

.markdown-body h1 {
display: block;
}

> :first-child {
:first-child {
margin-block-start: 0;
Expand Down
5 changes: 5 additions & 0 deletions packages/assets/styles/classes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,7 @@ a,
// MARKDOWN

.markdown-body {
overflow-y: auto;
h1:first-child {
margin-top: 0;
}
Expand All @@ -856,6 +857,10 @@ a,
line-height: 1.5;
}

h1 {
display: block;
}

h1,
h2 {
padding: 10px 0 5px;
Expand Down
4 changes: 3 additions & 1 deletion packages/utils/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@ export const configuredXss = new FilterXSS({
kbd: ['id'],
input: ['checked', 'disabled', 'type'],
iframe: ['width', 'height', 'allowfullscreen', 'frameborder', 'start', 'end'],
img: [...(whiteList.img || []), 'usemap', 'style'],
img: [...(whiteList.img || []), 'usemap', 'style', 'align'],
map: ['name'],
area: [...(whiteList.a || []), 'coords'],
a: [...(whiteList.a || []), 'rel'],
td: [...(whiteList.td || []), 'style'],
th: [...(whiteList.th || []), 'style'],
picture: [],
source: ['media', 'sizes', 'src', 'srcset', 'type'],
p: [...(whiteList.p || []), 'align'],
div: [...(whiteList.p || []), 'align'],
},
css: {
whiteList: {
Expand Down
Loading