Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App redesign #2946

Merged
merged 37 commits into from
Dec 12, 2024
Merged

App redesign #2946

merged 37 commits into from
Dec 12, 2024

Conversation

Prospector
Copy link
Member

No description provided.

@imheavi
Copy link

imheavi commented Nov 17, 2024

Will there be some sort of changelog covering the redesign?

import { type ContentItem } from './ContentListItem.vue'
import { DropdownIcon } from '@modrinth/assets'
// @ts-ignore
import { RecycleScroller } from 'vue-virtual-scroller'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vue-virtual-scroller library causes a serious bug in WebKit that freezes the entire app on some devices (#1127). This makes most of the app unusable, as I can’t access my projects.

To fix it, please switch to another virtual list library like vue-typed-virtual-list. I’ve used it before (example: 797e1f1), though it had some issues with logs not attaching to the bottom. However, this shouldn’t affect the projects list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix before release

@modrinth modrinth deleted a comment from Norbiros Nov 17, 2024
@Prospector
Copy link
Member Author

Let's not publicly post photos

@Tschipcraft
Copy link

I found this concept for redesigning the app settings page on the Labrinth Discord server by voxelfloof (Vox in a box):
https://www.figma.com/proto/Z6tildUhsoWNM7pQjW4VEO/Modrinth-Concepts?scaling=contain&content-scaling=fixed

Thought it looked really nice and could be used as inspiration

@Geometrically Geometrically merged commit c39bb78 into main Dec 12, 2024
3 of 4 checks passed
@Geometrically Geometrically deleted the app-redesign branch December 12, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants