Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Test::Mojo::content_* methods #1591

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

rage311
Copy link
Contributor

@rage311 rage311 commented Oct 30, 2020

Summary

Added Test::Mojo::content_* tests. If it seems like I'm on the right path here, I can continue adding tests for more methods.

Motivation

Part of addressing #1488

References

#1488

@kraih kraih requested a review from a team October 30, 2020 10:24
kraih
kraih previously requested changes Oct 30, 2020
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits.

@mergify mergify bot dismissed kraih’s stale review October 30, 2020 18:35

Pull request has been modified.

@kraih kraih requested a review from a team November 1, 2020 12:43
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mergify mergify bot merged commit 34a9c4e into mojolicious:master Nov 2, 2020
@rage311
Copy link
Contributor Author

rage311 commented Nov 3, 2020

Sorry to be a bother, as I realize this isn't your problem, but it seems these pull requests weren't counted toward Hacktoberfest as the hacktoberfest label was removed from the mojo project and they must not have done their validity checks before that happened. In lieu of re-adding the hacktoberfest label to the project, it seems you can also add a hacktoberfest-accepted label to this pull request, which should also make it count. If there's any chance that someone could add the hacktoberfest-accepted label to my 3 pull requests (#1592 and #1593 too), I would be very grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants