Use subtests t/mojo/template.t; issue #1520 #1914

tschaefer · 2022-02-11T22:33:55Z

Summary

Convert t/mojo/template.t to using subtests.

Motivation

See issue #1520

kathackeray

Tests pass. Same number of total tests/subtests after as before. Tests remain the same.

The $capture string variable is duplicated within 13 subtests with identical content for all.

$ ack 'my \$capture' t/mojo/template.t
  my $capture = 'no warnings "redefine"; sub capture { shift->(@_) }';
  my $capture = 'no warnings "redefine"; sub capture { shift->(@_) }';
  my $capture = 'no warnings "redefine"; sub capture { shift->(@_) }';
  ...

Arguably it could be declared once and reused. It doesn't seem to be subtest-specific and isn't modified. I'm approving the PR because the code is correct and functional. If somebody else fails it on the repetition, I'll know to be stricter next time.

kraih · 2022-02-25T12:13:17Z

Arguably it could be declared once and reused. It doesn't seem to be subtest-specific and isn't modified.

In tests it is more important to keep the scenarios isolated than to reduce duplicated code.

tschaefer · 2022-02-25T17:28:35Z

Sorry for the confusion. The close was not on purpose.

I just wanted to ask, if I should fit the indentation manually blamed in the perltidy check? The local run of perltidy with the given .perltidyrc doesn't bring the "wanted" result.

kathackeray · 2022-02-25T18:06:16Z

I have version v20211029 of perltidy locally, and running it on that file does produce the indentation changes. Might your version be older?

tschaefer · 2022-02-25T19:12:46Z

I'm using v20220217 same as in the related check. It's working from the command line not from within vim, seems some setup stuff from my side. Anyways, I'll force-push the commit.

kathackeray

Tests pass. Same number of total tests / subtests after as before. Perltidy passes.

Tests remain largely the same. However, I have highlighted a couple of small changes to the test input and expected responses, the reason for which is not explained in the issue as far as I can tell. I doubt this constitutes a fail.

kathackeray · 2022-03-09T14:32:13Z

t/mojo/template.t

-is $output, "<%# 1 + 1 %>\n", 'comment tag has been replaced';
+subtest 'Replace comment tag' => sub {
+  my $mt     = Mojo::Template->new;
+  my $output = $mt->render('<%%# \'1 + 1 %>');


Addition of ' to a test input and expected response. Test still passes, but unsure of the reason.

Yes, that should not have been added.

I can undo this unintentional adds. To be honest, to do this restructure of the tests is a kind of monkey job. So I tried to do it with some clever regex substitutions, seems that went not that well ... But anyways. I'll go on and try to convert at least one test each week.

kathackeray · 2022-03-09T14:34:14Z

t/mojo/template.t

-is $output, "  %# 1 + 1\n", 'comment line has been replaced';
+subtest 'Replace comment line' => sub {
+  my $mt     = Mojo::Template->new;
+  my $output = $mt->render('  %%# \'1 + 1');


Addition of ' to a test input and expected response. Test still passes, but unsure of the reason.

kathackeray · 2022-03-09T17:32:59Z

t/mojo/template.t

+subtest 'Multiline comment' => sub {
+  my $mt     = Mojo::Template->new;
+  my $output = $mt->render(<<'EOF');
+<html><%# 'this is


Another stray single quote

mergify · 2022-08-20T11:21:35Z