Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SakesHelperの定数まわりをリファクタ  #600

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

momocus
Copy link
Owner

@momocus momocus commented Mar 23, 2023

  • start_year_limitメソッドを定数にした
  • buttom_buttoleメソッドを、Sakeモデルの定数にした

関連 #594
(まだSakesControllerからIncludeを取り除けてない。プルリク大きくなりそうだから、いったんレビューリクエスト出すわ)

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (2e9a3cc) 95.49% compared to head (7d034d1) 95.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   95.49%   95.46%   -0.03%     
==========================================
  Files          16       16              
  Lines         311      309       -2     
==========================================
- Hits          297      295       -2     
  Misses         14       14              
Impacted Files Coverage Δ
app/controllers/sakes_controller.rb 97.97% <100.00%> (ø)
app/helpers/sakes_helper.rb 100.00% <100.00%> (ø)
app/models/sake.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@momocus momocus requested a review from yonta March 23, 2023 14:42
@momocus momocus marked this pull request as ready for review March 23, 2023 14:42
@yonta yonta merged commit 882957a into master Mar 23, 2023
@yonta yonta deleted the refactor-sakeshelper-constants branch March 25, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants