Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use an ISO date format for the date #5

Open
justdave opened this issue Jun 1, 2018 · 1 comment · May be fixed by #11
Open

Should use an ISO date format for the date #5

justdave opened this issue Jun 1, 2018 · 1 comment · May be fixed by #11

Comments

@justdave
Copy link

justdave commented Jun 1, 2018

/time tomorrow at noon posted on May 31st generates a message that states:

tomorrow at noon (Fri 06-01 6:00am HST, 9:00am MST, 10:00am MDT, 11:00am CDT, 12:00pm EDT, 1:00pm BT, 5:00pm BST, 6:00pm CEST, 7:00pm EEST, 11:00pm IT, Sat 06-02 12:00am TST, 2:00am AEST, 4:00am NZST)

That 06-01 is normally going to be read by many people outside the US as January 6th, not as June 1st. I'm not sure how to make it unambiguous without including the year or spelling out the month name.

timparenti added a commit to timparenti/channeltime that referenced this issue Sep 2, 2019
Use month abbreviations instead of numeric months, since day-of-week
abbreviation is already locale-dependent anyway.  Putting the day-of-month
before the month abbreviation avoids the need for a comma after the
day-of-week.

Resolves monkbroc#5.
@timparenti timparenti linked a pull request Sep 2, 2019 that will close this issue
@timparenti
Copy link

The existing format is actually already close to the format specified in ISO.8601.2000 (and referenced in RFC 6350) for dates without a year specified. --06-01, for instance, refers to 1 June in any year, as with a birthday or anniversary. However, that is not the context in which dates are being presented by this application.

Since the day-of-week is already being presented in a locale-dependent format, a month abbreviation can similarly be used, which resolves the potential ambiguity. #11 prefers to put the day-of-month before the month abbreviation to avoid the need for a separating comma; e.g., Fri 1 Jun instead of Fri, Jun 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants