This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Set the default value for Marionette to True #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selenium 4+ validates Capabilities now, and will not accept a Null value for a Boolean property (marionette). The real issue here is that the Selenium2Factory is very opionated and defaults to Firefox with a load of properties. This is the only one which is really problematic as the rest have either no default, or sensible defaults. Where a property has no default, it is considered optional, and is removed. Where a default is specified, then it will be applied. There is no way to entirely remove a property once specified using the Builder. The only way is to specify a new sensible default.
|
Copying from moodlehq/moodle-ci-runner#66 ... if we apply this fix to our very own https://github.com/moodlehq/MinkExtension.git fork... do we still need these PRs in the behat-extension ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium 4+ validates Capabilities now, and will not accept a Null value
for a Boolean property (marionette).
The real issue here is that the Selenium2Factory is very opionated and
defaults to Firefox with a load of properties.
This is the only one which is really problematic as the rest have either
no default, or sensible defaults.
Where a property has no default, it is considered optional, and is
removed. Where a default is specified, then it will be applied.
There is no way to entirely remove a property once specified using the
Builder. The only way is to specify a new sensible default.