Revival #726
Merged
Revival #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to revive this repo.
First of all
babel-plugin-transform-react-remove-prop-typesintroduced a breaking change after0.4.19that doesn't work with babel 6 that is used in this project (for now), so I just fixed its' version to0.4.19until we update to babel 7.Second of all looks like tests were falling because of #681 which introduced breaking change to the lib since older versions of
reactdon't support lifecycle methods withUNSAFE_prefix. So we either need to change peer-dependency version or callUNSAFEversion of the hook incomponentWillRecievePropsto support older version (also we need to do this in https://github.com/moroshko/react-autosuggest since it's broken there too).