[ES-1887] Added additionalConfig validator and new client-mgmt apis #1016
+1,490
−759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Rana <[email protected]>
ase-101
reviewed
Dec 1, 2024
esignet-core/src/main/java/io/mosip/esignet/core/dto/ClientDetailCreateRequestV3.java
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Dec 1, 2024
esignet-core/src/main/java/io/mosip/esignet/core/validator/ClientAdditionalConfigValidator.java
Show resolved
Hide resolved
ase-101
reviewed
Dec 1, 2024
esignet-service/src/main/java/io/mosip/esignet/controllers/ClientManagementController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Rana <[email protected]>
…n-dev Signed-off-by: Sachin Rana <[email protected]>
ase-101
reviewed
Dec 10, 2024
esignet-core/src/main/java/io/mosip/esignet/core/validator/ClientAdditionalConfigValidator.java
Show resolved
Hide resolved
ase-101
reviewed
Dec 10, 2024
...t-core/src/main/java/io/mosip/esignet/core/util/ClientAdditionalConfigValidatorTestData.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Rana <[email protected]>
Signed-off-by: Sachin Rana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the testcases for ClientConfigConverter, I have only tested edge cases. In the converter we are just using objectmapper to convert the values and no other logic, so testing other scenarios will be like testing that library.
I have put ClientAdditionalConfigValidatorTestData.java in esignet-core util folder. Is there any better place to keep it? The data in it is used in two test files one in esignet-core and other in esignet-service.