[INJIMOB-2275] add support for EcdsaSecp256k1Signature2019 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vharsh
commented
Nov 17, 2024
certify-service/pom.xml
Outdated
Comment on lines
28
to
34
| <dependency> | ||
| <groupId>io.mosip.certify</groupId> | ||
| <artifactId>mock-certify-plugin</artifactId> | ||
| <version>0.3.0-SNAPSHOT</version> | ||
| <scope>system</scope> | ||
| <systemPath>/Users/harshvardhan/work/mosip/digital-credential-plugins/mock-certify-plugin/target/mock-certify-plugin-0.3.0-SNAPSHOT.jar</systemPath> | ||
| </dependency> |
vharsh
force-pushed
the
add_ec_keys
branch
2 times, most recently
from
7bd88de to
f79e685
Compare
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
vharsh
changed the title
vharsh
commented
Nov 18, 2024
Comment on lines
+122
to
+125
| KeyPairGenerateRequestDto ecK1Key = new KeyPairGenerateRequestDto(); | ||
| ecK1Key.setApplicationId(KeyManagerConstants.CERTIFY_ECK1_APPID); | ||
| ecK1Key.setReferenceId(KeyManagerConstants.EC_SECP256K1_SIGN); | ||
| keymanagerService.generateECSignKey("certificate", ecK1Key); |
There was a problem hiding this comment.
This does not work right now and errors out.
There was a problem hiding this comment.
@nagendra0721 Please look at this changeset as this was failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level tasks:
EcdsaSecp256k1Signature2019proof (spec)Upstream library changes(to fix keymanager issue)