[INJICERT-248] Simplify configuration of the well-known config (#49) #64
Conversation
vharsh
force-pushed
the
injicert-248-add
branch
2 times, most recently
from
3b138a2 to
7c9bd6c
Compare
certify-service/src/main/java/io/mosip/certify/services/VCIssuanceServiceImpl.java
Show resolved
Hide resolved
certify-service/src/main/java/io/mosip/certify/services/VCIssuanceServiceImpl.java
Outdated
Show resolved
Hide resolved
certify-service/src/main/java/io/mosip/certify/services/VCIssuanceServiceImpl.java
Outdated
Show resolved
Hide resolved
| @@ -27,7 +27,7 @@ mosip.certify.authn.filter-urls={ '${server.servlet.path}/issuance/credential', | |||
| mosip.certify.authn.issuer-uri=http://localhost:8088/v1/esignet | |||
| mosip.certify.authn.jwk-set-uri=http://localhost:8088/v1/esignet/oauth/.well-known/jwks.json | |||
| mosip.certify.authn.allowed-audiences={ '${mosipbox.public.url}${server.servlet.path}/issuance/credential', 'http://localhost:8088/v1/esignet/vci/credential' } | |||
|
|
|||
| mosip.certify.well-known.file.uri=https://raw.githubusercontent.com/mosip/inji-config/develop/certify-mock-openid4vci-wk.json | |||
There was a problem hiding this comment.
We should rename this file to certify-mock-identity-issuer-metadata.json.
Config files for other usecases should be renamed to match this naming convention.
There was a problem hiding this comment.
In the previous review Anusha had suggested to specify the Spec for well-known as well, i.e. openid4vci as there're other well-knowns as well.
ref: #49 (comment)
How about renaming it to certify-mock-identity-issuer-openid4vci-well-known.json ?
How many other well-known configurations do we expect to see in the Inji Stack/MOSIP Stack in the near future?
There was a problem hiding this comment.
It will not be immediate, so I suggest leaving the openid4vci part since it will make the file name too big.
There was a problem hiding this comment.
I actually mean to remove the openid4vci part from the name, but I think the file name is changed to just openid4vci
vharsh
force-pushed
the
injicert-248-add
branch
from
db9efe1 to
173f358
Compare
vharsh
force-pushed
the
injicert-248-add
branch
from
173f358 to
7c45f05
Compare
|
@jainhitesh9998 Here's the config PR for this changeset --> mosip/inji-config#378 |
) * [INJICERT-248] use well known config from spring from separate JSON file Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] fixup JSON formatting of well-known config Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] Fixup formatting & resource URL Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] add missing config for mock-identity Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] parse metadata when mediatype is text/plain Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] rename openid4vci well known file Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
mosip.certify.well-known.file.uri -> mosip.certify.issuer-metadata.config-url Signed-off-by: Harsh Vardhan <[email protected]>
vharsh
force-pushed
the
injicert-248-add
branch
from
19dd010 to
c937d45
Compare
Signed-off-by: Harsh Vardhan <[email protected]>
|
Approved, this changes has to go along with inji-config changes |
| @@ -45,6 +45,7 @@ mosip.certify.security.ignore-auth-urls=**/actuator/**,**/error,**/swagger-ui/** | |||
| ## ------------------------------------------ Discovery openid-configuration ------------------------------------------- | |||
| mosip.certify.discovery.issuer-id=${mosipbox.public.url}${server.servlet.path} | |||
| mosip.certify.authorization.url=http://localhost:8088 | |||
| mosip.certify.issuer-metadata.config-url=https://raw.githubusercontent.com/mosip/inji-config/develop/certify-mock-openid4vci-wk.json | |||
There was a problem hiding this comment.
I'll handle the docker compose setup in a separate PR.
this changeset has been added back again post config-server stabalization for easier configuration