Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INJICERT-657] add dev1 landregistry cache config #638

Open
wants to merge 2 commits into
base: release-0.5.x
Choose a base branch
from

Conversation

vharsh
Copy link
Member

@vharsh vharsh commented Dec 18, 2024

No description provided.

mosip.certify.cache.size={templatecache': 20}
# cache duration set to half-day
mosip.certify.templatecache-expire-seconds=43200
mosip.certify.cache.expire-in-seconds={'templatecache': ${mosip.certify.templatecache-expire-seconds}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not keep the cache section in the certify-default? Normally usecase specific, they will not change these much

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The templatecache is required only by DataProvider plugin and not the other plugin implementations such as mosipid, insurance, mock, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is ok, this config ideally will not create any issues right ?

Copy link
Member Author

@vharsh vharsh Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is ok, this config ideally will not create any issues right ?

No

mosip.certify.data-provider-plugin.issuer-public-key-uri=did:web:vharsh.github.io:DID:devcp2#key-0
mosip.certify.data-provider-plugin.issuer-uri=did:web:vharsh.github.io:DID:devcp2
mosip.certify.data-provider-plugin.issuer-public-key-uri=did:web:inji-config.github.io:dev1:postgreslandregistry#key-0
mosip.certify.data-provider-plugin.issuer-uri=did:web:inji-config.github.io:dev1:postgreslandregistry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this to the namespace ? like did:web:inji-config.github.io:dev1:cp1 etc.. ?
Also can you send the PR to make the change in gh pages branch also ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

@@ -2,21 +2,32 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

mosip.kernel.keymanager.hsm.keystore-pass=${softhsm.certify.cp2.security.pin}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a dev1 setup related change, we cannot commit this into release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants