-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INJICERT-657] add dev1 landregistry cache config #638
base: release-0.5.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Harsh Vardhan <[email protected]>
mosip.certify.cache.size={templatecache': 20} | ||
# cache duration set to half-day | ||
mosip.certify.templatecache-expire-seconds=43200 | ||
mosip.certify.cache.expire-in-seconds={'templatecache': ${mosip.certify.templatecache-expire-seconds}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not keep the cache section in the certify-default? Normally usecase specific, they will not change these much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The templatecache
is required only by DataProvider
plugin and not the other plugin implementations such as mosipid
, insurance
, mock
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is ok, this config ideally will not create any issues right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is ok, this config ideally will not create any issues right ?
No
mosip.certify.data-provider-plugin.issuer-public-key-uri=did:web:vharsh.github.io:DID:devcp2#key-0 | ||
mosip.certify.data-provider-plugin.issuer-uri=did:web:vharsh.github.io:DID:devcp2 | ||
mosip.certify.data-provider-plugin.issuer-public-key-uri=did:web:inji-config.github.io:dev1:postgreslandregistry#key-0 | ||
mosip.certify.data-provider-plugin.issuer-uri=did:web:inji-config.github.io:dev1:postgreslandregistry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep this to the namespace ? like did:web:inji-config.github.io:dev1:cp1 etc.. ?
Also can you send the PR to make the change in gh pages branch also ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
Signed-off-by: Harsh Vardhan <[email protected]>
@@ -2,21 +2,32 @@ | |||
# License, v. 2.0. If a copy of the MPL was not distributed with this | |||
# file, You can obtain one at https://mozilla.org/MPL/2.0/. | |||
|
|||
mosip.kernel.keymanager.hsm.keystore-pass=${softhsm.certify.cp2.security.pin} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a dev1 setup related change, we cannot commit this into release branch.
No description provided.