Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring updates from OpenNotebookLLM. #3

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Bring updates from OpenNotebookLLM. #3

merged 2 commits into from
Dec 4, 2024

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 25, 2024

  • pyproject.toml
  • src structure
  • api docs
  • tests

@daavoo
Bring updates from OpenNotebookLLM.
6cd6136 
- pyproject.toml
- src structure
- api docs
- tests
@daavoo daavoo added the enhancement New feature or request label Nov 25, 2024
@daavoo daavoo self-assigned this Nov 25, 2024
Kostis-S-Z
Kostis-S-Z reviewed Nov 25, 2024
View reviewed changes
demo/app.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@daavoo daavoo requested a review from Kostis-S-Z December 4, 2024 10:40
Kostis-S-Z
Kostis-S-Z reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Kostis-S-Z Kostis-S-Z left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Maybe we could also

  • Update .gitignore to include .idea/ and .vscode similarly to the document-to-podcast
  • Add more structure to the README based on document-to-podcast, specifically:
    • Center the blueprints logo
    • Add 👉 📖 For more detailed guidance on using this project, please visit our [Docs here](https://mozilla-ai.github.io/document-to-podcast/).
    • Move Quick-start header before the Pre-requisites header
    • Add How it works header after the Quick-start header
  • I have started this which I ll finish in the next hour or so, so maybe we can also pull from here.

@daavoo
Copy link
Contributor Author

daavoo commented Dec 4, 2024 

* Update `.gitignore` to include `.idea/` and `.vscode` similarly to the `document-to-podcast`

Done.

* Add more structure to the README based on `document-to-podcast`, specifically:

I think this will be taken care by @stefanfrench as part of mozilla-ai/document-to-podcast#31

* I have started [this](https://github.com/mozilla-ai/document-to-podcast/pull/35) which I ll finish in the next hour or so, so maybe we can also pull from here.

I think is ok for you to send that update on a separate PR

@daavoo daavoo requested a review from Kostis-S-Z December 4, 2024 12:16
@daavoo daavoo merged commit a78c303 into main Dec 4, 2024
2 checks passed
@daavoo daavoo deleted the updates-from-opennotebookllm branch December 4, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kostis-S-Z Kostis-S-Z Kostis-S-Z approved these changes

@stefanfrench stefanfrench Awaiting requested review from stefanfrench

Assignees

@daavoo daavoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daavoo @Kostis-S-Z