17 implement cli based interaction #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
17-implement-cli-based-interaction
branch
from
4e95724 to
1bded51
Compare
|
@daavoo - Did an early test of this and its working well - tested on codespaces and worked end-to-end with the output saving. thanks for also updating the docs. |
daavoo
force-pushed
the
17-implement-cli-based-interaction
branch
from
bd56198 to
caae572
Compare
- Refactor speakers part of the config.
daavoo
force-pushed
the
17-implement-cli-based-interaction
branch
from
fe55a78 to
bf5698b
Compare
daavoo
requested review from
Kostis-S-Z,
stefanfrench and
a team
and removed request for
Kostis-S-Z and
stefanfrench
|
@daavoo - Thanks for this, a lot of work here!
|
Taking a look 👀 |
@stefanfrench I think this is fixed now |
stefanfrench
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
- Tested CLI works
- Tested updated streamlit app works
- Tested mkdocs serve
All working as expected, approved for merge. Thanks for the big effort on this. I think we will need to update the customiozation guide docs based on the changes, but we can do that in a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
cli.pyand expose it as entrypoint.configand refactor how speaker configuration is handled.mock.e2etests that can be run throughworkflow_dispatch(takes too much time to be enabled by default)How to test it