Separate dev dependencies and add pre-commit support (#304)

* Adding support for dev dependencies

* Adding new dependencies with pre-commit

* Adding debug

* Dockerfile test

* Fixing run installation and other bugs

* Adding common uv for pre-commit

* Adding target to the action

* Changing lock file back

---------

Signed-off-by: Mario Cariñana <[email protected]>

.devcontainer/docker-compose.override.yaml

@@ -3,6 +3,9 @@ name: lumigator
 services:
 
   backend:
-    command: ["uv", "run", "uvicorn", "backend.main:app", "--host", "0.0.0.0", "--port", "8000",  "--reload"]
+    build:
+      context: .
+      dockerfile: "Dockerfile"
+      target: "dev_image"
     volumes:
       - ./:/mzai

.github/workflows/build_images_uv.yaml

@@ -51,6 +51,7 @@ jobs:
         with:
           platforms: linux/amd64,linux/arm64
           push: true
+          target: "main_image"
           tags: |
             mzdotai/lumigator:backend_dev_${{ env.REPOVERSION }}
             ${{ github.ref == 'refs/heads/main' && 'mzdotai/lumigator:latest' || '' }}

.python-version

@@ -0,0 +1 @@
+3.11

Dockerfile

@@ -1,13 +1,21 @@
-FROM python:3.11-slim-bookworm
+FROM python:3.11-slim-bookworm AS base
 COPY --from=ghcr.io/astral-sh/uv:latest /uv /bin/uv
 
 # Copy the project into the image
 ADD . /mzai
 
-
 WORKDIR /mzai/lumigator/python/mzai/backend
 
-# Sync the project into a new environment, using the frozen lockfile
+FROM base AS main_image
+
+# Sync the project into a new environment, using the frozen lockfile and no dev dependencies
+RUN uv sync --no-dev --frozen
+
+CMD ["uv", "run", "--no-dev", "uvicorn",  "--host", "0.0.0.0", "--port", "8000", "backend.main:app"]
+
+FROM base AS dev_image
+
+# Sync the project into a new environment, using the frozen lockfile and no dev dependencies
 RUN uv sync --frozen
 
-CMD ["uv", "run", "uvicorn",  "--host", "0.0.0.0", "--port", "8000", "backend.main:app"]
+CMD ["uv", "run", "uvicorn", "backend.main:app", "--host", "0.0.0.0", "--port", "8000",  "--reload"]

Makefile

@@ -18,6 +18,7 @@ DEV_DOCKER_COMPOSE_FILE:= .devcontainer/docker-compose.override.yaml
 # Launches Lumigator in 'development' mode (all services running locally, code mounted in)
 local-up: 
 	RAY_ARCH_SUFFIX=$(RAY_ARCH_SUFFIX) docker compose --profile local -f $(LOCAL_DOCKERCOMPOSE_FILE) -f ${DEV_DOCKER_COMPOSE_FILE} up -d --build
+	uv run pre-commit install
 
 local-down:
 	docker compose --profile local -f $(LOCAL_DOCKERCOMPOSE_FILE) down

docker-compose.yaml

@@ -83,6 +83,7 @@ services:
     build:
       context: .
       dockerfile: "Dockerfile"
+      target: "main_image"
     platform: linux/amd64
     depends_on:
       localstack:
@@ -125,4 +126,4 @@ services:
 
 volumes:
 
-    localstack-data:
+    localstack-data:

pyproject.toml

@@ -0,0 +1,8 @@
+[project]
+name = "common"
+version = "0.1.0"
+description = "Common deps to develop"
+requires-python = ">=3.11"
+dependencies = [
+    "pre-commit>=4.0.1",
+]