Enable usage inside GitHub Codespaces #355
Conversation
format=experiment failed with:
```
{
"detail": [
{
"type": "enum",
"loc": [
"body",
"format"
],
"msg": "Input should be 'job'",
"input": "experiment",
"ctx": {
"expected": "'job'"
}
}
]
}
```
- Use sample_data in the example.
There was a problem hiding this comment.
By default GitHub uses .devcontainer/devcontainer.json when creating a codespace. Since the existing one is not meant to be used in codespaces, perhaps it could be moved to a subfolder like .devcontainer/local/devcontainer.json?
I think that sounds like a good idea, I think the only place that would need updating might be the actual contents of the devcontainer.json as it has relative references to where to find the docker 'stuff'. Do you think this should be done in a follow-up PR?
Since I am not really using the current TBH, having the |
|
Since it is not clear if this direction makes sense for the Lumigator and the changes are quite simple, I am closing this for now to avoid clutter |
What's changing
This P.R. adds a new file
.devcontainer/codespaces/devcontainer.jsonthat allows to run and test Luminator inside GitHub CodespacesHow to test it
Create a codespace from the GitHub UI using
New with options:Make sure to select this branch and the
Lumigatorconfig:Additional notes for reviewers
By default GitHub uses
.devcontainer/devcontainer.jsonwhen creating a codespace. Since the existing one is not meant to be used in codespaces, perhaps it could be moved to a subfolder like.devcontainer/local/devcontainer.json?I already...
Went through the full quickstart inside a codespace: