GHA: Update names of workflow jobs #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithin GitHub's UI
peteski22
requested review from
macaab26,
chainlink,
agpituk and
javiermtorres
macaab26
approved these changes
Nov 14, 2024
Co-authored-by: javiermtorres <[email protected]> Signed-off-by: Peter Wilson <[email protected]>
Co-authored-by: javiermtorres <[email protected]> Signed-off-by: Peter Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
GitHub's UI can make it difficult to know for sure which task you're trying to associate with a required status check as it resolves only the job name and shows no information about the scope (i.e. the workflow name it is associate with).
This PR makes the job names more specific as to which workflow they are part of.
Once the PR merges it will be easier to find and configure the required status checks for PRs merging to
main.How to test it
Additional notes for reviewers
Current branch protection rules for main only have a few checks configured, but we'd want more to be successful before allowing a merge.
This way we can ensure that we don't accidentally merge with changes that wouldn't pass our linting for example.
I already...