Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test version generation with versioningit #362

Closed
wants to merge 4 commits into from

Conversation

javiermtorres
Copy link
Contributor

@javiermtorres javiermtorres commented Nov 14, 2024

What's changing

Version tags for distributable packages can be set up using the repository tags instead of hardcoding them in the pyproject.toml files. This PR starts with the schemas repository; whatever method is decided will be applied to the SDK package as well.

The chosen package is versioningit, but suggestions are welcome. Some reference links to read are:

How to test it

The following items cover the known procedures where version generation could fail:

  • Go to lumigator/python/mzai/schemas and do uv build. Then check the package names in the dist directory.
  • Go to lumigator/python/mzai/sdk and do uv build. Then check the package names in the dist directory.
  • Start the dev container using make local-up. Everything should work as expected.
  • Start the dev container using make start-lumigator-build and run the SDK integration tests. Everything should work as expected.

Additional notes for reviewers

I already...

  • added some tests for any new functionality
    • manual test instructions added
  • updated the documentation
    • not added yet at this stage
  • checked if a (backend) DB migration step was required and included it if required
    • the issue is build-related, a db migration is not needed

@javiermtorres javiermtorres linked an issue Nov 14, 2024 that may be closed by this pull request
@javiermtorres javiermtorres force-pushed the javiermtorres/dynamic-package-versions branch from 40ba788 to 9ffa547 Compare November 14, 2024 16:11
@javiermtorres javiermtorres force-pushed the javiermtorres/dynamic-package-versions branch from 9ffa547 to 90f1165 Compare November 14, 2024 16:17
@javiermtorres javiermtorres marked this pull request as ready for review November 14, 2024 16:25
@javiermtorres
Copy link
Contributor Author

Please also suggest alternative workflows (updating the pyproject.toml on CI, for example) that we could consider.

@github-actions github-actions bot added sdk backend schemas Changes to schemas (which may be public facing) labels Nov 26, 2024
@javiermtorres
Copy link
Contributor Author

Closed as #425 will be implemented instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend schemas Changes to schemas (which may be public facing) sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic versioning
1 participant