-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test instructions #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @javiermtorres docs++;
!
I added some two suggestions, but I have two comments that maybe are more general than the improvements this PR brings.
- Should we look at moving some of the information in these
README
files to our operations guide? - Do you think (in other places too) we should make it clear that when the user does
SQLALCHEMY_DATABASE_URL=sqlite:///local.db ...
to run tests, it creates (or uses if it already exists) a SQLite DB that isn't removed afterwards?
🤔
On the one hand, I do believe this belongs to https://github.com/mozilla-ai/lumigator/blob/main/docs/source/operations-guide/dev.md (also, maybe). |
It's a good point :-/ Maybe in a separate PR we should add a step in tests to remove this file, plus set this env var directly as a fixture (and maybe use So yes, I'll add a line about it, at the very least. |
Co-authored-by: Peter Wilson <[email protected]> Signed-off-by: javiermtorres <[email protected]>
Co-authored-by: Peter Wilson <[email protected]> Signed-off-by: javiermtorres <[email protected]>
We should separate both. Right now the focus should be on Dev side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes.
@peteski22 @davidmanzanoai @dpoulopoulos if it's ok with you, in another PR:
If you agree with the current status plus the scope of the proposed future PR, please approve this PR. Thanks in advance, |
What's changing
Add more detailed instructions for testing the SDK and the backend.
How to test it
Check that the instructions match our current practice and the CI.
Additional notes for reviewers
N/A
I already...