-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable experiment endpoint #377
Conversation
0b8a657
to
2f4c347
Compare
Signed-off-by: javiermtorres <[email protected]>
89d5545
to
9628c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! At least the UI will not have to worry about what we decide regarding tracking, workflows, etc. :)
Tested it as well (upload dialogsum, launch experiment based on the included ground-truth), listed experiments, downloaded experiment results.
lumigator/python/mzai/backend/backend/api/routes/experiments.py
Outdated
Show resolved
Hide resolved
By the way, we're going to need to introduce some tests for this one - current tests (not even integration ones) do not cover this functionality. |
Roger and wilco :) |
Co-authored-by: I. Vidal <[email protected]> Signed-off-by: javiermtorres <[email protected]>
Co-authored-by: I. Vidal <[email protected]> Signed-off-by: javiermtorres <[email protected]>
I'd like to better understand the use-case for this. Generally, it would make sense to write a separate experiment service and we decide on how we'd like tracking to work at the experiment level. I'd be hesitant at this stage to mix |
The goal is to abstract API consumers from the changes around I completely agree with you that jobs are a different abstraction, which is why /experiments/evaluation and experiments/inference were not something that we intended folks to use, they were a temporary by-product. Here, the functionality folks could rely on was " In the near future, we'll have to decide how exactly experiments will collect/trigger/x multiple jobs and how we track them. Until then, the UI doesn't need to care and can still use them as an entrypoint to workflows. |
lumigator/python/mzai/backend/backend/tests/api/routes/test_api_workflows.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a tiny thing there and I'd merge. We're far from sorting out clean jobs, experiments and tracking here, but this is a small step to not bothering UI with the debate.
What's changing
An experiment endpoint reusing the jobs service is made available.
How to test it
N/A for the moment
Additional notes for reviewers
N/A for the moment
I already...