Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for job decoupling discussion #379

Closed
wants to merge 2 commits into from

Conversation

javiermtorres
Copy link
Contributor

@javiermtorres javiermtorres commented Nov 17, 2024

What's changing

A new generic create_job_alt is proposed. The key changes are:

  • Job data are retrieved from a dict, which allows programmatic changes in the future, and a more general config and use right now
  • Job config models are stored in the same dict from a statically imported file
    • Currently models are used in standalone scripts, so they need to be added to lumigator somehow
      • The image build process could include these files somehow (maybe using the mechanisms in https://hatch.pypa.io/latest/config/build/)
      • The models could be included in lumigator itself, and the scripts could import the lumigator_schemas package
    • More dynamic imports using importlib to load models at load-time or run-time could be done later on without changes to the current job creation
  • Additional steps can be added as hooks, if needed, in the same way that the model code is added

The current code has not been checked; once the approach is validated, a full, working implementation will be provided.

How to test it

N/A; draft for discussion at the moment.

Additional notes for reviewers

N/A

I already...

  • added some tests for any new functionality
  • updated the documentation
  • checked if a (backend) DB migration step was required and included it if required

@javiermtorres javiermtorres force-pushed the javiermtorres/job-decoupling branch from 55cf29e to ae868ad Compare November 20, 2024 10:19
@javiermtorres
Copy link
Contributor Author

Closing this PR as the issue has been discussed internally and issues have been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant