Separating out setting model type into a separate method in the job service #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adding ruff precommit hooks here because they're not getting caught before they reach the linter in CI |
aittalam
reviewed
Nov 19, 2024
aittalam
reviewed
Nov 19, 2024
lumigator/python/mzai/backend/backend/tests/services/test_job_service.py
Outdated
Show resolved
Hide resolved
aittalam
reviewed
Nov 19, 2024
lumigator/python/mzai/backend/backend/tests/services/test_job_service.py
Outdated
Show resolved
Hide resolved
aittalam
approved these changes
Nov 19, 2024
github-actions
bot
added
sdk
backend
api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
We currently have a lot going on in the
create_jobmethod which makes it hard to unit test granularly. We've previously done some work in pulling out separate methods (see #328), this PR does the same for_set_model_typeand adds tests also clarifying the model URL (it wouldn't be S3 since we use either huggingface, openai or mistral at the moment) in the SDK.How to test it
Run unit tests
Additional notes for reviewers
I already...
cc @peteski22 @javiermtorres fyi for SDK changes