Code cleanup

mozilla · Nov 19, 2024 · d9fc589 · d9fc589
1 parent 803538a
commit d9fc589
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 18 deletions.
diff --git a/.java-version b/.java-version
diff --git a/rhino/src/main/java/org/mozilla/javascript/IRFactory.java b/rhino/src/main/java/org/mozilla/javascript/IRFactory.java
@@ -538,9 +538,7 @@ private Node transformElementGet(ElementGet node) {
 
     private Node transformExprStmt(ExpressionStatement node) {
         Node expr = transform(node.getExpression());
-        Node exprStatementNode = new Node(node.getType(), expr);
-        exprStatementNode.setLineColumnNumber(node.getLineno(), node.getColumn());
-        return exprStatementNode;
+        return new Node(node.getType(), expr, node.getLineno(), node.getColumn());
     }
 
     private Node transformForInLoop(ForInLoop loop) {

diff --git a/rhino/src/main/java/org/mozilla/javascript/Parser.java b/rhino/src/main/java/org/mozilla/javascript/Parser.java
@@ -590,7 +590,8 @@ private AstRoot parse() throws IOException {
         AstRoot root = new AstRoot(pos);
         currentScope = currentScriptOrFn = root;
 
-        int baseLineno = prevNameTokenLineno = ts.lineno; // line number where source starts
+        int baseLineno = ts.lineno; // line number where source starts
+        prevNameTokenLineno = ts.getLineno();
         prevNameTokenColumn = ts.getTokenColumn();
         int end = pos; // in case source is empty
 
@@ -1445,7 +1446,6 @@ private IfStatement ifStatement() throws IOException {
         pn.setElsePart(ifFalse);
         pn.setElsePosition(elsePos);
         pn.setLineColumnNumber(lineno, column);
-
         return pn;
     }
 
@@ -2491,7 +2491,6 @@ private AstNode assignExpr() throws IOException {
             if (isNotValidSimpleAssignmentTarget(pn))
                 reportError("msg.syntax.invalid.assignment.lhs");
 
-            Node left = pn;
             pn = new Assignment(tt, pn, assignExpr(), opPos);
 
             if (jsdocNode != null) {
@@ -2901,7 +2900,6 @@ private AstNode memberExpr(boolean allowCallSyntax) throws IOException {
         } else {
             consumeToken();
             int pos = ts.tokenBeg, lineno = lineNumber(), column = columnNumber();
-            ;
             NewExpression nx = new NewExpression(pos);
 
             AstNode target = memberExpr(false);

diff --git a/rhino/src/main/java/org/mozilla/javascript/TokenStream.java b/rhino/src/main/java/org/mozilla/javascript/TokenStream.java
@@ -2452,15 +2452,7 @@ public int getLength() {
     }
 
     public int getTokenColumn() {
-        return getTokenColumn(tokenBeg);
-    }
-
-    /**
-     * @param tokenPosition absolute start of the token position
-     * @return the 1-indexed column
-     */
-    public int getTokenColumn(int tokenPosition) {
-        return tokenPosition - tokenStartLastLineEnd + 1;
+        return tokenBeg - tokenStartLastLineEnd + 1;
     }
 
     // stuff other than whitespace since start of line

diff --git a/rhino/src/main/java/org/mozilla/javascript/ast/InfixExpression.java b/rhino/src/main/java/org/mozilla/javascript/ast/InfixExpression.java
@@ -94,7 +94,7 @@ public AstNode getLeft() {
     public void setLeft(AstNode left) {
         assertNotNull(left);
         this.left = left;
-        // line number should agree with source position
+        // line and column number should agree with source position
         setLineColumnNumber(left.getLineno(), left.getColumn());
         left.setParent(this);
     }