Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update static getProperty(Scriptable, Symbol) to no longer throw when not SymbolScriptable #1615

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update static getProperty(Scriptable, Symbol) to no longer throw when not SymbolScriptable #1615

wants to merge 4 commits into from

Commits on Sep 13, 2024

  1. remove explicit public declarations 

    interface methods are implicitly public and it is best practice to not explicitly specify public
    @tonygermano
    tonygermano committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ecf88c0 View commit details
    Browse the repository at this point in the history

  2. Make SymbolScriptable extend Scriptable 

    It is already expected that objects which implement SymbolScriptable also implement Scriptable. Make this expectation enforced.
    @tonygermano
    tonygermano committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1637c51 View commit details
    Browse the repository at this point in the history

  3. Move static putProperty methods from ScriptableObject to Scriptable. … 

    …Symbol-based method no longer throws

Methods in ScriptableObject have been deprecated.
    @tonygermano
    tonygermano committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    872049a View commit details
    Browse the repository at this point in the history

  4. Update references from deprecated to new methods. 

    ScriptableObject.getProperty methods have been replaced by Scriptable.getProperty. Also remove redundant super interface Scriptable from classes which implement SymbolScriptable.
    @tonygermano
    tonygermano committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    519cb58 View commit details
    Browse the repository at this point in the history