-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test on macOS 14 with upstream clang #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have no working experience with Apple platforms, so your help here is greatly appreciated.
It seems we have some runtime issues with precision on a new platform for some unit tests. Could you please fix it on your side as I have no way to repo this in my environment? |
Ah, here is now that small precision loss in the trigonometric functions due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
macOS 14 is the only platform that tests on arm64 on GitHub Actions (and is available for public repos). We already test on macOS 14, but so far only with Apple Clang. Apple Clang isn't a widely known compiler in terms of standards compliance, so test with upstream clang should be valuable. In particular, Apply Clang doesn't seem to warn about prevision loss from
long
tolong double
, but upstream clang does. Thus, with this PR, we actually detect the causes of issue #611. #611 is already fixed on master, so the (fast-forward) merge should fix the CI issues that will appear.