-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature tests analysis #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned flbulgarelli
Dec 28, 2018
ghost
added
the
pending-review
label
Dec 28, 2018
flbulgarelli
force-pushed
the
feature-tests-analysis
branch
2 times, most recently
from
January 1, 2019 16:32
8cf51dc
to
1d24420
Compare
We should document that now mulang
|
julian-berbel
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
julian-berbel
force-pushed
the
feature-tests-analysis
branch
from
January 3, 2019 13:49
8b5848a
to
9a00a0d
Compare
ghost
assigned julian-berbel
Jan 3, 2019
With latest commit, I converted this PR into a backward-compatible change. See #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing new interpreter-based test analysis through CLI and JS API.
Also, I opted-in the remaining mandatory options from the CLI.
Pending:
ghcjs
build. Tested in Issue #217 info update #218TestAnalyzer
,Runner
, andTests
modules whose separation has become less clear after this change.Implement the proposed interpreter-flags. This is mostly outside the scope of this PR, but I wanted to already share my thoughts 😛See Implement interpreter flags #216