[GHA] 'site' should run on 'prepare release' commit #3302
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to deploy the site when we release new version, however, with the current 'if' condition, the 'site' action does not run on the target commit. The commit message of a release starts with "[maven-release-plugin] prepare release".
|
@harawata I understand, that would mean it would no longer submit a site for snapshot but would send just final updates. That is probably better given we release so infrequently and snapshot data gives false impression if we have new features we don't yet make available. So I'd say go ahead and do that and send up do that point to the site branch to make sure it does as you need. If that works, we should do that elsewhere. |
hazendaz
approved these changes
Nov 27, 2024
|
Will let you merge it since it has some follow up work to confirm it works as you expect. |
|
Thanks @hazendaz ! We are going to have to wait for the next release to see how this works 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to deploy the site when we release new version, however, with the current 'if' condition, the 'site' action does not run on the target commit.
The commit message of a release starts with "[maven-release-plugin] prepare release".