Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker deployment #333

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KhadijaMahanga
Copy link

This PR enables developers to develop, deploy and run mapit on docker containers.

Files added:

  • Dockerfile
  • docker-compose.yml
  • docker-entrypoint.sh
  • runtume.txt
  • CHECKS

Files modified:

  • project/settings.py
  • project/ urls.py - to serve static files

@ghost ghost added the Current label Jan 25, 2019
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files          38       38           
  Lines        2157     2157           
=======================================
  Hits         1354     1354           
  Misses        803      803

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466f072...2a73113. Read the comment docs.

@sagepe
Copy link
Member

sagepe commented Feb 26, 2019

Thanks for your interest in MapIt and for submitting a pull request!

We are adding Docker support to some of our projects, so it was interesting to see how you have approached this.

However, I'm sorry to say that we can't accept this PR in its current format.

We'd prefer a slightly different approach to the structure of the Dockerfile with the aim of reducing layers and final image size. For example RUN line can be combined when installing dependencies, recommended packages should be omitted unless necessary and apt metadata and cache can be removed following installation.

The PR contains files that are not directly related to the Docker build or the compose file but rather concerned with particular deployment environments (eg the CHECKS file). It would be better if these were explained in dedicated commits or omitted entirely.

The commits also vary in content in that some extend functionality and some contain fix-ups to previous commits, often without any real explanation. At the PR stage, we'd prefer that fix-ups were rebased into the original commits.

If you are interesting in additional feedback, please let me know.

@DavidLemayian
Copy link
Contributor

Thanks @sagepe .

An in-line review would be great and we'll make the changes ASAP.

Also, we can definitely squash/rebase the commits in the branch to clean up commits. Are there any guidelines on commit messages?

And lastly, I notice vagrant is still the choice of the day. Would it be more useful to just open an issue and let the core team prioritise the switch to Docker so as not to mess up the code / documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants