-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker deployment #333
base: master
Are you sure you want to change the base?
Docker deployment #333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 62.77% 62.77%
=======================================
Files 38 38
Lines 2157 2157
=======================================
Hits 1354 1354
Misses 803 803 Continue to review full report at Codecov.
|
Thanks for your interest in MapIt and for submitting a pull request! We are adding Docker support to some of our projects, so it was interesting to see how you have approached this. However, I'm sorry to say that we can't accept this PR in its current format. We'd prefer a slightly different approach to the structure of the The PR contains files that are not directly related to the Docker build or the compose file but rather concerned with particular deployment environments (eg the The commits also vary in content in that some extend functionality and some contain fix-ups to previous commits, often without any real explanation. At the PR stage, we'd prefer that fix-ups were rebased into the original commits. If you are interesting in additional feedback, please let me know. |
Thanks @sagepe . An in-line review would be great and we'll make the changes ASAP. Also, we can definitely squash/rebase the commits in the branch to clean up commits. Are there any guidelines on commit messages? And lastly, I notice vagrant is still the choice of the day. Would it be more useful to just open an issue and let the core team prioritise the switch to Docker so as not to mess up the code / documentation? |
21f5add
to
8547a77
Compare
This PR enables developers to develop, deploy and run mapit on docker containers.
Files added:
Dockerfile
docker-compose.yml
docker-entrypoint.sh
runtume.txt
CHECKS
Files modified:
project/settings.py
project/ urls.py
- to serve static files