Use escaped unicode for maximum compatibility #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SASS outputs the unicode values directly, which in certain scenarios (I'm using it in a very basic application-integrated web server for instance) can break due to lacklustre UTF8 handling.
This PR brings the output in line with Font-Awesome, where the content value in the output CSS is an escaped (I think that's what it's called?) unicode value (e.g. \eae1) rather than missing character square in most text editors so that it doesn't get mangled by any dodgy encoding, etc. As part of this, it removes the \ from the variables as the unicode function added to the mixins file will handle adding this during compilation