Detect browsers in a Deno-compatible way #821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use Tesseract.js in Deno, but currently I can't because of an incorrect runtime detection:
Unlike Node.js, Deno has
window
global so Tesseract.js misunderstands it's running in browsers. As Remix's doc suggests, checks fordocument
is preferred for this reason. This check is also backward compatible in other environments.I don't claim first-class support for Deno (of course, I'd be happy if you do), but I just wish if I could use Tesseract.js in Deno in some way.
You can find similar PRs merged at other popular libraries like motiondivision/motion#1522, TanStack/virtual#516, melt-ui/melt-ui#14, and chakra-ui/zag#694.